Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove self referencing link #46823

Merged
merged 1 commit into from
Jun 16, 2024
Merged

Remove self referencing link #46823

merged 1 commit into from
Jun 16, 2024

Conversation

ktvargo-ms
Copy link
Contributor

@ktvargo-ms ktvargo-ms commented Jun 14, 2024

removed self-referencing link per #46613

Tested locally with
make container-image
make container-serve
In a web browser, navigate to https://localhost:1313 and view changes

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jun 14, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 14, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @ktvargo-ms!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 14, 2024
Copy link

netlify bot commented Jun 14, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 5229cb2
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/666cafbfa0799000088e93a2
😎 Deploy Preview https://deploy-preview-46823--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stmcginnis
Copy link
Contributor

Makes sense - thanks!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 14, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0955a3b2d991beff46331f9c6be07ac490d5d523

@sftim
Copy link
Contributor

sftim commented Jun 16, 2024

/retitle Remove self referencing link

@k8s-ci-robot k8s-ci-robot changed the title removed self referencing link per #46613 Remove self referencing link Jun 16, 2024
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes sense. It would be even better to move the hyperlink after the line that reads <!--more-->.

Thank you for the pull request. We can merge it. Congratulations!
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2024
@k8s-ci-robot k8s-ci-robot merged commit 3e9c976 into kubernetes:main Jun 16, 2024
6 checks passed
@ktvargo-ms ktvargo-ms deleted the 46613 branch June 17, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants