-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated note on "Set up a High Availability etcd Cluster with kubeadm" page #48120
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the intent was to remove the {{< note >}}
block, so we should also remove the shortcode itself.
content/en/docs/setup/production-environment/tools/kubeadm/setup-ha-etcd-with-kubeadm.md
Outdated
Show resolved
Hide resolved
content/en/docs/setup/production-environment/tools/kubeadm/setup-ha-etcd-with-kubeadm.md
Outdated
Show resolved
Hide resolved
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
/sig cluster-lifecycle |
Co-authored-by: Dipesh Rawat <rawat.dipesh@gmail.com>
Co-authored-by: Dipesh Rawat <rawat.dipesh@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The preview page (here) renders fine now (note
removed).
/lgtm
LGTM label has been added. Git tree hash: e3238055daed649bc411a687d064e40a6bffe744
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
/lgtm
/sig cluster-lifecycle
/triage accepted
/label tide/merge-method-squash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good to merge.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dipesh-rawat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…th kubeadm" page (kubernetes#48120) * Remove note from setup-ha-etcd-with-kubeadm.md * Remove note from setup-ha-etcd-with-kubeadm.md Co-authored-by: Dipesh Rawat <rawat.dipesh@gmail.com> * Remove note from setup-ha-etcd-with-kubeadm.md Co-authored-by: Dipesh Rawat <rawat.dipesh@gmail.com> --------- Co-authored-by: Dipesh Rawat <rawat.dipesh@gmail.com>
Removed the note from the https://kubernetes.io/docs/setup/production-environment/tools/kubeadm/setup-ha-etcd-with-kubeadm/ page as given solution in comment #47818 (comment)
Closes #47818