Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated note on "Set up a High Availability etcd Cluster with kubeadm" page #48120

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

steve-hardman
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Sep 28, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 28, 2024
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the intent was to remove the {{< note >}} block, so we should also remove the shortcode itself.

Copy link

netlify bot commented Sep 28, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit c6a0214
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66f9e01973138d00082297ad
😎 Deploy Preview https://deploy-preview-48120--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dipesh-rawat
Copy link
Member

/sig cluster-lifecycle

@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Sep 28, 2024
steve-hardman and others added 2 commits September 30, 2024 00:17
Co-authored-by: Dipesh Rawat <rawat.dipesh@gmail.com>
Co-authored-by: Dipesh Rawat <rawat.dipesh@gmail.com>
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The preview page (here) renders fine now (note removed).

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 30, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e3238055daed649bc411a687d064e40a6bffe744

Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

/lgtm
/sig cluster-lifecycle
/triage accepted

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Oct 1, 2024
@dipesh-rawat
Copy link
Member

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Oct 1, 2024
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to merge.
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dipesh-rawat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2024
@k8s-ci-robot k8s-ci-robot merged commit 40419a5 into kubernetes:main Oct 1, 2024
6 checks passed
@steve-hardman steve-hardman deleted the issue-47818 branch October 7, 2024 19:26
jimangel pushed a commit to jimangel/website that referenced this pull request Oct 30, 2024
…th kubeadm" page (kubernetes#48120)

* Remove note from setup-ha-etcd-with-kubeadm.md

* Remove note from setup-ha-etcd-with-kubeadm.md

Co-authored-by: Dipesh Rawat <rawat.dipesh@gmail.com>

* Remove note from setup-ha-etcd-with-kubeadm.md

Co-authored-by: Dipesh Rawat <rawat.dipesh@gmail.com>

---------

Co-authored-by: Dipesh Rawat <rawat.dipesh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated note/link on page "Set up a High Availability etcd Cluster with kubeadm"
4 participants