-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix up CRD glossary term #7428
fix up CRD glossary term #7428
Conversation
Deploy preview for kubernetes-io-master-staging ready! Built with commit 6ae5ed8 https://deploy-preview-7428--kubernetes-io-master-staging.netlify.com |
/approve |
Hello everyone, and thanks @Bradamant3 for bringing this up. I agree that there's a lot of different perspectives and suggestions placed in the comments. At the time during the docs sprint, I wasn't sure what I going up against and unsure what suggestions/comments hold more weight. Getting it fixed has been on my do list since. Like to convey that I'm still very interested in working on this. 😄 |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: heckj, steveperry-53 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Bradamant3 Thanks for following up on this, and thanks @Bubblemelon for sticking with it! 🌟 |
See PR #6594. This was a PR embarrassingly from the docs sprint at Kubecon Austin 2017. After too many revised commits and reviews from multiple competing perspectives, I figured we should merge and then fix up separately.
/assign @steveperry-53 @chenopis @heckj @zacharysarah
(mostly adding y'all to the PR so that maybe we can take a lesson learned or two as we work on process and guidelines going forward. Discuss?)
This change is