Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix up CRD glossary term #7428

Merged
merged 1 commit into from
Feb 16, 2018
Merged

fix up CRD glossary term #7428

merged 1 commit into from
Feb 16, 2018

Conversation

Bradamant3
Copy link
Contributor

@Bradamant3 Bradamant3 commented Feb 16, 2018

See PR #6594. This was a PR embarrassingly from the docs sprint at Kubecon Austin 2017. After too many revised commits and reviews from multiple competing perspectives, I figured we should merge and then fix up separately.
/assign @steveperry-53 @chenopis @heckj @zacharysarah
(mostly adding y'all to the PR so that maybe we can take a lesson learned or two as we work on process and guidelines going forward. Discuss?)


This change is Reviewable

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 16, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 6ae5ed8

https://deploy-preview-7428--kubernetes-io-master-staging.netlify.com

@steveperry-53
Copy link
Contributor

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2018
@Bubblemelon
Copy link
Contributor

Hello everyone, and thanks @Bradamant3 for bringing this up. I agree that there's a lot of different perspectives and suggestions placed in the comments.

At the time during the docs sprint, I wasn't sure what I going up against and unsure what suggestions/comments hold more weight. Getting it fixed has been on my do list since. Like to convey that I'm still very interested in working on this. 😄

@heckj
Copy link
Contributor

heckj commented Feb 16, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 16, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: heckj, steveperry-53

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [heckj,steveperry-53]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e6d8bf7 into kubernetes:master Feb 16, 2018
@zacharysarah
Copy link
Contributor

@Bradamant3 Thanks for following up on this, and thanks @Bubblemelon for sticking with it! 🌟

bsalamat pushed a commit to bsalamat/kubernetes.github.io that referenced this pull request Feb 23, 2018
tehut pushed a commit to tehut/website that referenced this pull request Mar 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants