Restart crashed plugins #1236
Merged
Restart crashed plugins #1236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mszostok
force-pushed
the
watch-plugins-v2
branch
2 times, most recently
from
e386275
to
4d59ca5
Compare
huseyinbabal
reviewed
Sep 8, 2023
| @@ -1187,6 +1187,13 @@ plugins: | |||
| enabled: true | |||
| port: 2115 | |||
| targetPort: 2115 | |||
| # -- Botkube Restart Policy on plugin failure. | |||
| restartPolicy: | |||
There was a problem hiding this comment.
So, to better understand: It will do the heatlhcheck each 10s and if it restarts 5 times, the plugin will be disabled with this setup, am I correct?
There was a problem hiding this comment.
exactly, however I think that we can bump the disable threshold to ~10 because for now it's for the whole life of the plugin, until the botkube pod won't be restarted. I would like to change it to but probably in the follow-up PRs.
huseyinbabal
reviewed
Sep 8, 2023
huseyinbabal
approved these changes
Sep 8, 2023
mszostok
force-pushed
the
watch-plugins-v2
branch
from
4d59ca5
to
d0aa112
Compare
Co-authored-by: Josef Karasek josef@kubeshop.io
mszostok
force-pushed
the
watch-plugins-v2
branch
from
d0aa112
to
9f7b7fa
Compare
mszostok
added a commit
that referenced
this pull request
Sep 8, 2023
Co-authored-by: Josef Karasek <josef@kubeshop.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Restart crashed plugins based on Restart crashed plugins #1204
runningProcessesto support plugin name in the context of a given configurationINFO[2023-09-07T17:05:44+02:00] Starting server on %q...:2115 component="Incoming Webhook Serverstill todo:
Testing
Co-authored-by: Josef Karasek josef@kubeshop.io