Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add single quote escaping while parsing input command #1433

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Add single quote escaping while parsing input command #1433

merged 1 commit into from
Apr 22, 2024

Conversation

mszostok
Copy link
Contributor

@mszostok mszostok commented Apr 18, 2024 •
edited

Description

Changes proposed in this pull request:

  • Add single quote escaping while parsing input command. It's more like a workaround. Ultimately, we should find a better and more generic way for extracting parameters. Additionally, we should delegate command tokenizing to the plugin. However, this would require a bigger refactor, so I deduced to not go into that direction right now.

Related issue(s)

@mszostok mszostok added the bug Something isn't working label Apr 18, 2024
@mszostok mszostok marked this pull request as ready for review April 18, 2024 12:05
@mszostok mszostok requested review from PrasadG193 and a team as code owners April 18, 2024 12:05
madebyrogal
madebyrogal approved these changes Apr 19, 2024
View reviewed changes
Copy link
Collaborator

@madebyrogal madebyrogal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in this PR https://github.com/kubeshop/botkube-cloud-plugins/pull/21
Works like a harm!

@mszostok mszostok merged commit 3fd8bec into kubeshop:main Apr 22, 2024
17 of 18 checks passed
@mszostok mszostok deleted the quote-parsing branch April 22, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madebyrogal madebyrogal madebyrogal approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mszostok @madebyrogal