Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added count method #4985

Merged
merged 3 commits into from
Feb 9, 2024

Conversation

exu
Copy link
Member

@exu exu commented Feb 9, 2024

Pull request description

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

Breaking changes

Changes

Fixes

Copy link

netlify bot commented Feb 9, 2024

Deploy Preview for testkube-docs-preview canceled.

Name Link
🔨 Latest commit cce86dc
🔍 Latest deploy log https://app.netlify.com/sites/testkube-docs-preview/deploys/65c62606336bfd0008f55139

@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2024

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (1acd131) 26.31% compared to head (df1c6f1) 20.86%.

Files Patch % Lines
pkg/repository/result/mock_repository.go 0.00% 9 Missing ⚠️
pkg/repository/result/mongo.go 0.00% 3 Missing ⚠️
pkg/cloud/data/result/result.go 0.00% 2 Missing ⚠️
pkg/cloud/data/testresult/testresult.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4985      +/-   ##
===========================================
- Coverage    26.31%   20.86%   -5.46%     
===========================================
  Files          269      265       -4     
  Lines        24451    24146     -305     
===========================================
- Hits          6435     5038    -1397     
- Misses       17354    18661    +1307     
+ Partials       662      447     -215     
Flag Coverage Δ
integrationtests ?
unittests 20.86% <0.00%> (-0.67%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@exu exu merged commit a53f26e into develop Feb 9, 2024
11 checks passed
@exu exu deleted the jacek/fix/added-count-method-for-results-for-cloud branch February 9, 2024 13:31
exu added a commit that referenced this pull request Feb 9, 2024
* fix: added count method

* fix: added Count method to results and suites results

* fix: added cool down to flaky test
exu added a commit that referenced this pull request Feb 9, 2024
* fix: added count method

* fix: added Count method to results and suites results

* fix: added cool down to flaky test
vsukhin added a commit that referenced this pull request Feb 20, 2024
* fix: complete repository empty check (#4889)

* fix: complete repository empty check

* fix: extract method for empty check

* feat: Executor tests - JMeter/JMeterd - extended other cases, special cases (#4894)

* executor tests - jmeter-executor-smoke-2.jmx

* executor tests - jmeter - other and special cases extended

* end - empty line

* jmeter executor smoke - suite updated

* jmeter executor tests - special cases

* jmeter executor tests - special cases - testsuite

* executor tests - run script updated

* executor tests - branch name updated before merge

* end - empty line

* fix: pvc name

* feat: refactored logs stream to allow to be passed and initialized la… (#4892)

* feat: refactored logs stream to allow to be passed and initialized later with id

* feat: added logs for test scheduler errors

* fix: renamed repos

* fix: initialize logs stream only if logs v2 enabled

* Update pkg/logs/events/events.go

Co-authored-by: Lilla Vass <vLia@users.noreply.github.com>

* fix: comments

* fix: added logs

* fix: logs metghod

---------

Co-authored-by: Lilla Vass <vLia@users.noreply.github.com>

* fix: remove duplicates

* fix: unit tests

* fix: add OUTPUT_DIR env var

* fix: add unit tests

* fix: add more test cases

* fix: one more test case

* fix: slack token must be set to initialize Slack Listener (#4902)

* test cli image

* delete sha output

* feat: add status field to artifacts (#4908)

* feat: add minio log consumer with opts (#4867)

* feat: add minio log consumer with opts

* fix: tests

* fix: skip test

* fix: improve code and error handling

* fix: handle chunk too big

* fix: execute but return errors

* fix: minor improvements

* fix: contexts

* fix: fiber doesn't allow to use query string outside handler

* feat: Executor tests  - container executor - Gradle and Maven (#4898)

* executor tests - container executor - maven and gradle

* empty lines added

* empty lines added

* fix: dep update

* fix: dep update

* fix: add gradle home

* add support for skipping cert verification of presigned put urls (#4915)

* fix: trigger event for logs start (#4916)

* feat: trigger logs startstop events

* fix: single NATS construct func

* fix: use parametrized nats connection when creating encoded one (#4918)

* feat: trigger logs startstop events

* fix: single NATS construct func

* fix: added nats conn with valid opts

* build: bump follow-redirects from 1.15.1 to 1.15.4 in /docs (#4868)

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.1 to 1.15.4.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.15.1...v1.15.4)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: support missing run path

* fix: execution id not passed to events (#4920)

* fix: added cooldown time to not stop events too early (#4921)

* fix: execution id not passed to events

* fix: async stop

* fix: rollback to debug on message

* fix: context aware stop wait time

* fix: tests fixed with stop wait time

* fix: smaller docker file (#4919)

* docs: add CircleCI article (#4885)

* docs: add CircleCI article

* Update docs/docs/articles/circleci.md

Co-authored-by: Julianne Fermi <julianne@kubeshop.io>

* Update docs/docs/articles/circleci.md

Co-authored-by: Julianne Fermi <julianne@kubeshop.io>

* Update docs/docs/articles/circleci.md

Co-authored-by: Julianne Fermi <julianne@kubeshop.io>

* Update docs/docs/articles/circleci.md

Co-authored-by: Julianne Fermi <julianne@kubeshop.io>

* Update docs/docs/articles/circleci.md

Co-authored-by: Julianne Fermi <julianne@kubeshop.io>

* Update docs/docs/articles/circleci.md

Co-authored-by: Julianne Fermi <julianne@kubeshop.io>

* Update docs/docs/articles/circleci.md

Co-authored-by: Julianne Fermi <julianne@kubeshop.io>

* Update docs/docs/articles/circleci.md

Co-authored-by: Julianne Fermi <julianne@kubeshop.io>

* Update docs/docs/articles/circleci.md

Co-authored-by: Julianne Fermi <julianne@kubeshop.io>

---------

Co-authored-by: Julianne Fermi <julianne@kubeshop.io>

* feat: Executor tests jmeterd special cases extended, run script fixed (labels) (#4929)

* jmeterd executor tests - special cases extended

* tests - run script fixed (labels)

* empty lines added

* empty lines added

* Discord-Slack Migration (#4928)

Update docs to contain link to Slack channel.

* update cimfor logs service

* add manifest for logs service

* fix bug in manifest creation for logs services

* feat: executor tests - gradle and maven - tests extended, non-default executor tests fixed (#4930)

* executor tests - gradle and maven - tests extended, non-default executor tests - fixed

* empty lines added

* maven testsuite fixed

* chore: refactor of client.Client into client.StreamGetter (#4933)

* feat: executor tests - JMeterd special cases - incorrect filename (#4935)

* executor tests - jmeter special cases extended - incorrect file name

* empty lines added

* docs: add demo to docs overview (#4938)

* add demo to docs overview

* add demo to docs overview

* chore: refactor of stop function (#4934)

* feat: pass execution config to the logs

* fix: there is no map string any in grpc

* fix: rollback to map string string

* fix: improved logs message

* fix: stop response async

* fix: tests

* fix: added test source to the log output

* fix: refactored stop function with retries and stream and consumer comparison

* fix: refactor of stop function with messages occurence handling

* jmeterd: add sanity checking for test file (#4947)

* fix: use pointer everywhere when passing log chunk (#4943)

* fix: use pointer everywhere when passing log chunk

* chore: refactor method name - no response prefix anymore

* fix: added source to old logs

* fix: cleaning how source is set for logs in proxy

* fix: pass feature flags to the executor

* chore: rename

* fix: passed features to constructors

* fix: streamLogs method in job executor

* build: bump github.com/go-playground/locales from 0.14.0 to 0.14.1 (#4869)

Bumps [github.com/go-playground/locales](https://github.com/go-playground/locales) from 0.14.0 to 0.14.1.
- [Release notes](https://github.com/go-playground/locales/releases)
- [Commits](go-playground/locales@v0.14.0...v0.14.1)

---
updated-dependencies:
- dependency-name: github.com/go-playground/locales
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build: bump github.com/itchyny/gojq from 0.12.9 to 0.12.14 (#4870)

Bumps [github.com/itchyny/gojq](https://github.com/itchyny/gojq) from 0.12.9 to 0.12.14.
- [Release notes](https://github.com/itchyny/gojq/releases)
- [Changelog](https://github.com/itchyny/gojq/blob/main/CHANGELOG.md)
- [Commits](itchyny/gojq@v0.12.9...v0.12.14)

---
updated-dependencies:
- dependency-name: github.com/itchyny/gojq
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build: bump github.com/charmbracelet/glamour (#4871)

Bumps [github.com/charmbracelet/glamour](https://github.com/charmbracelet/glamour) from 0.5.1-0.20220727184942-e70ff2d969da to 0.6.0.
- [Release notes](https://github.com/charmbracelet/glamour/releases)
- [Commits](https://github.com/charmbracelet/glamour/commits/v0.6.0)

---
updated-dependencies:
- dependency-name: github.com/charmbracelet/glamour
  dependency-type: indirect
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build: bump github.com/prometheus/client_golang from 1.16.0 to 1.18.0 (#4873)

Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.16.0 to 1.18.0.
- [Release notes](https://github.com/prometheus/client_golang/releases)
- [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md)
- [Commits](prometheus/client_golang@v1.16.0...v1.18.0)

---
updated-dependencies:
- dependency-name: github.com/prometheus/client_golang
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build: bump github.com/emicklei/go-restful/v3 from 3.11.0 to 3.11.2 (#4872)

Bumps [github.com/emicklei/go-restful/v3](https://github.com/emicklei/go-restful) from 3.11.0 to 3.11.2.
- [Release notes](https://github.com/emicklei/go-restful/releases)
- [Changelog](https://github.com/emicklei/go-restful/blob/v3/CHANGES.md)
- [Commits](emicklei/go-restful@v3.11.0...v3.11.2)

---
updated-dependencies:
- dependency-name: github.com/emicklei/go-restful/v3
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: added adapter stop (#4948)

* fix: adapter stop call after consumer stop (#4950)

* feat: add minio adapter for logs (#4942)

* feat: add minio adapter for logs

* fix: add all the minio config files

* fix: tests

* fix: parameters in creating

* fix: add more log info

* fix: rename minio adapter

* docs: update Jenkins article (#4949)

* docs: update Jenkins article

* docs: update sidebar

* chore: add jenkins plugin url

* chore: update jenkins docs env vars

* fix: use test start stop event (#4954)

* fix: use test start stop event

* fix: rename event

* fix: handle test start and stop events already present

* fix: tests

* fix: dummy adapter use structured logging (#4957)

* fix: dummy adapter use structured logging

* fix: golang ci fixes

* test logs sidecar

* test logs release

* release logs service

* add cosign

* remove testing

* fix: duplicate merged args

* fix: remove unused parameter

* Add selected webhooks blog content to webhooks doc. (#4958)

* fix: refactor merge args

* fix: remove custom assertion logic in jmeterd executor (#4966)

* fix: remove custom assertion logic in jmeterd executor

* fix: fix failign jmeterd integration test

* docs: instructions for using Jenkins Plugin via the UI (#4956)

* docs: update Jenkins article

* docs: update sidebar

* chore: add jenkins plugin url

* chore: update jenkins docs env vars

* docs: Jenkins via UI articles

* Update docs/docs/articles/jenkins-ui.md

Co-authored-by: Julianne Fermi <julianne@kubeshop.io>

* Update docs/docs/articles/jenkins-ui.md

Co-authored-by: Julianne Fermi <julianne@kubeshop.io>

* Update docs/docs/articles/jenkins-ui.md

Co-authored-by: Julianne Fermi <julianne@kubeshop.io>

* Update docs/docs/articles/jenkins-ui.md

Co-authored-by: Julianne Fermi <julianne@kubeshop.io>

* Update docs/docs/articles/jenkins-ui.md

Co-authored-by: Julianne Fermi <julianne@kubeshop.io>

* Update docs/docs/articles/jenkins-ui.md

Co-authored-by: Julianne Fermi <julianne@kubeshop.io>

---------

Co-authored-by: Julianne Fermi <julianne@kubeshop.io>

* docs: Azure DevOps Pipelines (#4968)

* docs: update Jenkins article

* docs: update sidebar

* chore: add jenkins plugin url

* chore: update jenkins docs env vars

* docs: Jenkins via UI articles

* docs: Azure Pipelines integration

* Update docs/docs/articles/azure.md

Co-authored-by: Julianne Fermi <julianne@kubeshop.io>

* Update docs/docs/articles/azure.md

Co-authored-by: Julianne Fermi <julianne@kubeshop.io>

* Apply suggestions from code review

Co-authored-by: Julianne Fermi <julianne@kubeshop.io>

---------

Co-authored-by: Julianne Fermi <julianne@kubeshop.io>

* feat: JMeter/JMeterd - executor tests and special cases extended (#4972)

* JMeterd - incorrect url 2

* JMeter/JMeterd - executor tests, and special cases extended

* fix: fixing timeouts (#4971)

* fix: fixing timeouts

* fix: podStartTimeout increased

* feat: refactored for cloud logs service (#4973)

* feat: refactored for cloud logs service

* fix: commment

* fix: renamed mapper

* fix: panic when trying to stop second time

* feat: cloud adapter (#4975)

* feat: added cloud adapter

* fix: tests for cloud adapter

* fix: tests for cloud adapter

* fix: test server concurrent write/read error

* fix: assertion

* fix: data races in emitter

* fix: data races in emitter

* feat: logv2 api (#4936)

* feat: add minio repository get

* fix: implement minio log repository

* fix: switch to interface

* fix: pass log stream to factory

* fix: add minio client

* fix: move print logic into separate method

* fix: switch back to non json reader

* fix: return err

* feat: features model for api

* fix: send features in api response

* fix: debug logs v2

* feat: don't send logs by agent in v2

* fix: unit tests

* fix: separate v1 and v2 logs methods

* feat: add log model

* feat: add log v2 spec

* feat: unit tests for logs v2 api

* fix: error message

* fix: error message

* fix: comment

* fix: minio unit test

* fix: unit test

* fix: make chanel later

* fix: return output for logs v1 and v2

* fix: remove check

* fix: support both v1 and v2 logs reading

* fix: logs v1 prefix

* fx: for not found log states use minio

* fix: remove empty line

* fix: unit test

* featL cli watch logs v2

* fix: cli typo

* fix: add completed message

* fix: log reading error

* fix: change default bucket

* feat: use last modified time for logs v1

* fix: unit tests

* fix: don't send not completed output

* fix: v2 routes

* fix: support watch for run command

* fix: grpc client creates endless loops (#4976)

* fix: minor renames for minio adapter (#4974)

* fix: minor renames for minio adapter

* fix: logs

* fix: unused var

* fix: args mode replace

* Update docs/docs/articles/creating-tests.md

Co-authored-by: Lilla Vass <vLia@users.noreply.github.com>

* fix: log finish handled correctly (#4978)

* fix: log finish handled correctly

* chore: use init instead of copied function

* fix: generate mocks

* fix: tests

* fix: duplicated logs when watching results in real time (#4981)

* feat: get executor by test type

* fixL nik map

* fix: unescape test type

* fix: suppot override mode

* fix: unit test

* fix: add more unit tests

* fix: added count method (#4985)

* fix: added count method

* fix: added Count method to results and suites results

* fix: added cool down to flaky test

* fix: use user OUTPUT_DIR

* feat: executor tests - jmeter `negative` disabled after exit code changes, `jmeterd-executor-smoke-output-dir` (#4996)

* executor tests - jmeterd-executor-smoke-output-dir

* typo fixed

* empty lines added

* fix: switch to query instead of path param

* fix: return path to script check

* executor tests - jmeterd-executor-smoke-slaves-sharedbetweenpods excluded from testsuite (have to be run at specific cluster with NFS volume) (#4999)

* fix: update cloud env vars to pro (#4994)

* fix: cloud env vars rename to pro

* fix: update cloud env vars to pro

* fix: kill application when on 2nd termination signal provided (#5002)

* feat: Executor tests - pre/post run script cases (#5003)

* executor tests - expected failures extended - pre/post-run script for container executor

* executor tests - expected failures testsuite extended

* executor tests - expected failures - failed test, passed pre/post-run scripts

* empty lines added

* chore: ignore mocks in the code coverage (#5006)

* feat: improve the Docker image inspection to cache the results in Memory and/or ConfigMap (#5005)

* fix: rollback NewMongoREpository construct function to not be changed (#5008)

* fix: removed unnecessary values from cloud only constructors (#5010)

* feat: grpc tls (#5001)

* feat: add client tls cert for log server

* fix: change config file

* fix: unit test

* feat: grpc server tls

* fix: unit test

* fix: switch to mounted secrets

* fix: error message

* fix: don't send nil creds

* fix: non init structure

* fix: nil pointer in compose slack message (#5011)

* fix: remove uuid from metrics

* fix: rename outout dir

* fix: remove duplicate -n

* feat: logs grpc server for get logs (#5028)

* fix: remove dirs duplication

* fix: dep update

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: nicufk <nicolae@kubeshop.io>
Co-authored-by: Tomasz Konieczny <tomasz.konieczny@kubeshop.io>
Co-authored-by: Jacek Wysocki <jacek.wysocki@gmail.com>
Co-authored-by: Lilla Vass <vLia@users.noreply.github.com>
Co-authored-by: ypoplavs <yulia.poplavska@kubeshop.io>
Co-authored-by: Povilas Versockas <p.versockas@gmail.com>
Co-authored-by: Dejan Zele Pejchev <pejcev.dejan@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Catalin <20538711+devcatalin@users.noreply.github.com>
Co-authored-by: Julianne Fermi <julianne@kubeshop.io>
Co-authored-by: Ale <93217218+alelthomas@users.noreply.github.com>
Co-authored-by: Dawid Rusnak <dawid@drcode.pl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants