feat: change the Test Workflow orchestration mechanism to atomic instructions #5676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rangoo94
force-pushed
the
dawid/chore/detach-container-name-of-ref
branch
from
20ccf70
to
ba35d0a
Compare
✅ Deploy Preview for testkube-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for testkube-docs-preview canceled.
|
…ions / grouping them, based on the TestWorkflowProcessor's Stages
…ng multiple steps in single container
vsukhin
reviewed
Jul 26, 2024
vsukhin
reviewed
Jul 26, 2024
vsukhin
reviewed
Jul 26, 2024
vsukhin
reviewed
Jul 26, 2024
vsukhin
reviewed
Jul 26, 2024
vsukhin
reviewed
Jul 26, 2024
vsukhin
reviewed
Jul 26, 2024
vsukhin
reviewed
Jul 26, 2024
vsukhin
reviewed
Jul 26, 2024
vsukhin
reviewed
Jul 26, 2024
vsukhin
reviewed
Jul 26, 2024
vsukhin
reviewed
Jul 26, 2024
vsukhin
reviewed
Jul 26, 2024
vsukhin
reviewed
Jul 26, 2024
vsukhin
reviewed
Jul 26, 2024
vsukhin
approved these changes
Jul 26, 2024
rangoo94
added a commit
that referenced
this pull request
Aug 14, 2024
…ructions (#5676) * fix(testworkflows): avoid unnecessary empty data in ContainerConfig * feat(testworkflows): add basic implementation to build list of operations / grouping them, based on the TestWorkflowProcessor's Stages * feat(testworkflows): migrate basics of container execution for handling multiple steps in single container * feat: support conditions with new Init Process kind * feat: encapsulate init process' container state * chore: rename container to setup * feat: support dynamic environment variables * feat: add mock for pause in the Init Process * feat: discriminate TestWorkflow instructions with ActionType * chore: rename Paused to PausedOnStart * chore: change StepData mutations * chore: extract action.Action to separate package * feat: move *Stage to separate package * chore: reorganize action files * chore: delete unused * chore: extract lightweight version of actions to avoid increase in Init Process size * feat: abstract the executions in the Init Process * fix: aborting Test Workflow processes * fix: support statuses properly in the Init Process * fix: parsing container logs * chore: delete debug information * feat: make the root operation constant * feat: support timeout for Test Workflow steps * feat: add back retry functionality for the Test Workflows * feat: support pause/resume for Test Workflows * chore: delete unused code * fix: watching services * fix: some unit tests * chore: add instructions check in unit test * chore: refactor action unit tests a bit * fix: build correct conditions when there are grouped steps * chore: adjust processor tests * chore: delete unused function * feat: streamline the output in the Init Process, to allow obfuscating sensitive words * feat: mask secret environment variables * chore: extract function to get last step * chore: unify internal machine for Init Process * chore: move step timeout logic to the Init Process main switch * fix: use default ContainerConfig for setup step container * feat: use /bin/sh instead of /.tktw/bin/sh in case the Init/Toolkit image is used * chore: fail property accessor in case of nullish value to access * feat: ensure that aborted step is considered aborted, not skipped * fix: machine for retry in the Init Process * chore: rename `instructions` related to Actions to `actions` * fix: send again toolkit/init image data along with Pod information from Test Workflow * chore: simplify StepStatusFromCode * fix: clean up printing in the Init Process * chore: clean up getting actions in Processor tests * chore: rename variable in Control Server * chore: extract control server options to separate file * chore: expose a bit configuration of sensitive words minimum length * chore: delete obsolete todos * fix: avoid copying binaries from the Init image when it's not necessary * fix: unit tests * fix: group conditions * chore: wrap errors * chore: reduce the size of Init Process * fix: detect the Toolkit properly * chore: rename SensitiveReadWriter to Obfuscator * feat: show last characters in the obfuscated log output * feat: make some environment variables sensitive by default * chore: first set of code review fixes * chore: make the 00 and 01 special groups constants * chore: log error for mkdir of working directory * chore: delete commented out code * fix: handle errors in the setup step
rangoo94
added a commit
that referenced
this pull request
Aug 14, 2024
…ructions (#5676) * fix(testworkflows): avoid unnecessary empty data in ContainerConfig * feat(testworkflows): add basic implementation to build list of operations / grouping them, based on the TestWorkflowProcessor's Stages * feat(testworkflows): migrate basics of container execution for handling multiple steps in single container * feat: support conditions with new Init Process kind * feat: encapsulate init process' container state * chore: rename container to setup * feat: support dynamic environment variables * feat: add mock for pause in the Init Process * feat: discriminate TestWorkflow instructions with ActionType * chore: rename Paused to PausedOnStart * chore: change StepData mutations * chore: extract action.Action to separate package * feat: move *Stage to separate package * chore: reorganize action files * chore: delete unused * chore: extract lightweight version of actions to avoid increase in Init Process size * feat: abstract the executions in the Init Process * fix: aborting Test Workflow processes * fix: support statuses properly in the Init Process * fix: parsing container logs * chore: delete debug information * feat: make the root operation constant * feat: support timeout for Test Workflow steps * feat: add back retry functionality for the Test Workflows * feat: support pause/resume for Test Workflows * chore: delete unused code * fix: watching services * fix: some unit tests * chore: add instructions check in unit test * chore: refactor action unit tests a bit * fix: build correct conditions when there are grouped steps * chore: adjust processor tests * chore: delete unused function * feat: streamline the output in the Init Process, to allow obfuscating sensitive words * feat: mask secret environment variables * chore: extract function to get last step * chore: unify internal machine for Init Process * chore: move step timeout logic to the Init Process main switch * fix: use default ContainerConfig for setup step container * feat: use /bin/sh instead of /.tktw/bin/sh in case the Init/Toolkit image is used * chore: fail property accessor in case of nullish value to access * feat: ensure that aborted step is considered aborted, not skipped * fix: machine for retry in the Init Process * chore: rename `instructions` related to Actions to `actions` * fix: send again toolkit/init image data along with Pod information from Test Workflow * chore: simplify StepStatusFromCode * fix: clean up printing in the Init Process * chore: clean up getting actions in Processor tests * chore: rename variable in Control Server * chore: extract control server options to separate file * chore: expose a bit configuration of sensitive words minimum length * chore: delete obsolete todos * fix: avoid copying binaries from the Init image when it's not necessary * fix: unit tests * fix: group conditions * chore: wrap errors * chore: reduce the size of Init Process * fix: detect the Toolkit properly * chore: rename SensitiveReadWriter to Obfuscator * feat: show last characters in the obfuscated log output * feat: make some environment variables sensitive by default * chore: first set of code review fixes * chore: make the 00 and 01 special groups constants * chore: log error for mkdir of working directory * chore: delete commented out code * fix: handle errors in the setup step
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request description
start,end,execute,containerordeclareChecklist (choose whats happened)