Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: avoid getting image metadata from container registry when it is not needed #5727

Conversation

rangoo94
Copy link
Member

@rangoo94 rangoo94 commented Aug 5, 2024

Pull request description

  • When there is information about working directory, user group and command/shell provided for each of the steps, avoid calling the Container Registry for additional metadata.
    • additionally image.command, image.args and image.workingDir variables should not be used

Example Test Workflow

kind: TestWorkflow
apiVersion: testworkflows.testkube.io/v1
metadata:
  name: workflow-without-inspecting-images
spec:
  container:
    workingDir: /data
    securityContext:
      runAsGroup: 1000
  job:
    activeDeadlineSeconds: 60
  steps:
  - run:
      image: busybox
      shell: pwd && tree /data
  - run:
      image: busybox
      command:
      - /bin/sh
      - -c
      args:
      - echo 'hello'
  - run:
      image: busybox
      command:
      - /bin/sh
      - -c
      - echo 'hello again'
  - run:
      image: blah-unknown-image:1234
      shell: echo not executed because of unknown image

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

@rangoo94 rangoo94 requested a review from a team as a code owner August 5, 2024 11:37
Copy link

netlify bot commented Aug 5, 2024

Deploy Preview for testkube-docs-preview ready!

Name Link
🔨 Latest commit 1794a42
🔍 Latest deploy log https://app.netlify.com/sites/testkube-docs-preview/deploys/66b0b97537083f00081516a2
😎 Deploy Preview https://deploy-preview-5727--testkube-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rangoo94 rangoo94 merged commit 3549562 into develop Aug 6, 2024
14 checks passed
@rangoo94 rangoo94 deleted the dawid/feat/ignore-fetching-image-metadata-when-all-required-information-is-provided branch August 6, 2024 07:31
rangoo94 added a commit that referenced this pull request Aug 14, 2024
rangoo94 added a commit that referenced this pull request Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants