fix(cli): fix upsert for environments #2570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
danielbdias
requested changes
May 23, 2023
| return result, err | ||
| if envResource.Spec.GetId() != "" { | ||
| _, err := environment.Get(ctx, envResource.Spec.GetId()) | ||
| if err != nil { |
There was a problem hiding this comment.
We need to add validation here because we need guarantees that this error happens because of a missing entity.
One way is to emit a specialized error like "ResourceNotFound" to do that. I did this here: 9e9ec20#diff-660f1c4de144c4d56d5c007996cd5725aa2bb25a43caf6cb6f7600424790062fR154
I've added this validation on my CLI e2e branch to print a "Resource not found message" in case of a user asks for an entity that doesn't exist.
danielbdias
reviewed
May 23, 2023
schoren
force-pushed
the
fix-environments-cli
branch
from
1743d70
to
d1e576a
Compare
schoren
force-pushed
the
fix-environments-cli
branch
from
d1e576a
to
b0f75af
Compare
danielbdias
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes environment upsert in cli
Checklist