Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(frontend): removing decross option for the dat layout #2594

Merged
merged 1 commit into from May 26, 2023
Merged

fix(frontend): removing decross option for the dat layout #2594

merged 1 commit into from May 26, 2023

Conversation

xoscar
Copy link
Collaborator

@xoscar xoscar commented May 26, 2023 •
edited

This PR removes the decross option from the dag layout setup, as it breaks with large traces

Related issue erikbrinkman/d3-dag#98

Changes

  • Removes decross option from dag layout setup

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@xoscar xoscar self-assigned this May 26, 2023
@xoscar xoscar marked this pull request as ready for review May 26, 2023 03:15
@xoscar xoscar merged commit d90178d into main May 26, 2023
27 checks passed
@xoscar xoscar deleted the fix/test-run-dag branch May 26, 2023 11:22
schoren pushed a commit that referenced this pull request Jun 5, 2023
@xoscar @schoren
fix(frontend): removing decross option for the dat layout (#2594)
d679768
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgeepc jorgeepc jorgeepc approved these changes

@danielbdias danielbdias Awaiting requested review from danielbdias

Assignees

@xoscar xoscar

Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xoscar @jorgeepc