Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: There is no need to maintain so many docker images #26

Closed
JohnNiang opened this issue Jun 2, 2021 · 7 comments
Closed

Discussion: There is no need to maintain so many docker images #26

JohnNiang opened this issue Jun 2, 2021 · 7 comments

Comments

@JohnNiang
Copy link
Member

There is no need to maintain so many docker images for dedicated requirements. The main shortage of devops-agent we provided is that we can't change tools' version conveniently in Jenkinsfile, and to do that we have to build another docker image for dedicated tool version. The world has too many tools we don't want to build them twice.

However, maybe we can change our mind, we could provide another way that users could config and apply their pod templates easily. If do that, we'll be free.

@JohnNiang
Copy link
Member Author

JohnNiang commented Jun 2, 2021

/area devops
/kind optimization

@ks-ci-bot
Copy link
Collaborator

@JohnNiang: The label(s) kind/proposal cannot be applied, because the repository doesn't have them

In response to this:

/area devops
/kind proposal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JohnNiang JohnNiang changed the title There is no need to maintain so many docker images Proposal: There is no need to maintain so many docker images Jun 2, 2021
@JohnNiang
Copy link
Member Author

There is also an example about custom pod template:

pipeline {
  agent {
    kubernetes {
      //cloud 'kubernetes'
      label 'node:fermium'
      yaml """
apiVersion: v1
kind: Pod
spec:
  containers:
  - name: nodejs
    image: node:fermium
    command: ['cat']
    tty: true
"""
    }
  }
  stages {
    stage('Run nodejs') {
      steps {
        container('nodejs') {
          sh '''
          node -v
          npm -v
          yarn -v
          '''
        }
      }
    }
  }
}

If we could put the custom pod template into global pod template easily, it would be very nice.

@LinuxSuRen
Copy link
Member

I don't know what do you want to propose here. Please give a clear to-do list instead of just an idea. And the pros and cons for each item are necessary.

By the way, where does the image come from if you propose to use a custom pod template?

@JohnNiang JohnNiang changed the title Proposal: There is no need to maintain so many docker images Discussion: There is no need to maintain so many docker images Jun 3, 2021
@Dishone
Copy link
Contributor

Dishone commented Nov 18, 2021

@LinuxSuRen Hi Rick, when I was building my flutter image proxy last night. I thought of a design. We can allow users to customize the image they need by providing a web interface. Similar to s2ibuilders. This is just an initial idea, I think I can help.

@LinuxSuRen
Copy link
Member

see also #75
/close

@ks-ci-bot
Copy link
Collaborator

@LinuxSuRen: Closing this issue.

In response to this:

see also #75
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants