vSphere: Fix security context of VDDK validation pod #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #776 +/- ##
=========================================
+ Coverage 0 16.89% +16.89%
=========================================
Files 0 88 +88
Lines 0 17933 +17933
=========================================
+ Hits 0 3030 +3030
- Misses 0 14658 +14658
- Partials 0 245 +245
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
ok, apparently on k8s we can't avoid setting it so we'd need to differentiate k8s from OpenShift.... |
The previous attempt to fix the execution of the VDDK validation pod didn't succeed - it allowed to run it on the 'default' namespace but its execution failed on other retricted namespaces in which the QEMU user (107) is not included in the allowed range. In order to fix this properly on OpenShift, we drop RunAsNonRoot and RunAsUser so that OpenShift would pick a proper user based on the configuration of the namespace. Signed-off-by: Arik Hadas <ahadas@redhat.com>
ahadas
force-pushed
the
vddk_validation_drop_security_context
branch
from
5d9984a
to
cf0d402
Compare
|
I don't expect the latest changes to pass our CI, need additional changes for k8s |
Signed-off-by: Arik Hadas <ahadas@redhat.com>
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous attempt to fix the execution of the VDDK validation pod didn't succeed - it allowed to run it on the 'default' namespace but its execution failed on other restricted namespaces in which the QEMU user (107) is not included in the allowed range.
In order to fix this properly, we differentiate OpenShift from k8s: in case of OpenShift we don't specify RunAsNonRoot and RunAsUser in order to let the platform choose an appropriate user, and in case of k8s, we specify the QEMU user (107)