Backport 2.6 fixes #783
Merged
Backport 2.6 fixes #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In OCP 4.15, CDI dropped their annotation of the import disk ID. We added an annotation `forklift.konveyor.io/disk-source` before to the DataVolumes only which propagates to the PersistentVolumeClaim. Now it will also be included on other non-CDI flows. This change is made as we used the CDI annotation to be an identifier when importing a disk. Not having it caused an NPE. Now we will use the forklift annotation. Signed-off-by: Liran Rotenberg <lrotenbe@redhat.com>
When validating a plan we have specific logic that applies for source providers of type OpenShift but the check of the type of the source provider didn't take into consideration that the source provider may be invalid, leading to a sig fault. Here we extend the function that validates the source providers of type OpenShift with nil-check of the source provider as done in other validation function for a plan. Signed-off-by: Arik Hadas <ahadas@redhat.com>
Similar to the previous change that added a nil-check for the source provider when validating a plan, here we add a nil-check for the destination provider thay may also be invalid when posting a plan via the command line. Signed-off-by: Arik Hadas <ahadas@redhat.com>
Move secret setup to the top, as VM validation is skipped when the plan is executing which can lead to an NPEin checks that rely on it Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
… for status. Signed-off-by: Bella Khizgiyaev <bkhizgiy@redhat.com>
Signed-off-by: Bella Khizgiyaev <bkhizgiy@redhat.com>
Signed-off-by: Bella Khizgiyaev <bkhizgiy@redhat.com>
Signed-off-by: Arik Hadas <ahadas@redhat.com>
Signed-off-by: Bella Khizgiyaev <bkhizgiy@redhat.com>
Signed-off-by: Arik Hadas <ahadas@redhat.com>
The previous attempt to fix the execution of the VDDK validation pod didn't succeed - it allowed to run it on the 'default' namespace but its execution failed on other retricted namespaces in which the QEMU user (107) is not included in the allowed range. In order to fix this properly on OpenShift, we drop RunAsNonRoot and RunAsUser so that OpenShift would pick a proper user based on the configuration of the namespace. Signed-off-by: Arik Hadas <ahadas@redhat.com>
Signed-off-by: Arik Hadas <ahadas@redhat.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#770 #773 #776 #777 #779 #780