Fix: resolve static files not being built #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charlie Chiang <charlie_c_0129@outlook.com>
wonderflow
reviewed
Jun 22, 2022
| @@ -57,7 +57,8 @@ jobs: | |||
| git config --global user.email "actions@github.com" | |||
| git config --global user.name "gh-actions" | |||
| yarn add nodejieba | |||
| yarn install --frozen-lockfile | |||
| yarn install --frozen-lockfile --production=false | |||
There was a problem hiding this comment.
Suggested change
| yarn install --frozen-lockfile --production=false | |
| yarn install --frozen-lockfile --production=true |
Should we mark the production to be true?
There was a problem hiding this comment.
This should not be true, otherwise it will not install devDependencies (thus will not build anything). This parameter is added to tell yarn to install devDependencies, preventing accidental NODE_ENV=production causing build issues. The final product is not affected.
There was a problem hiding this comment.
Of course, there is no devDependencies in this repo lol (which --production makes no difference). This is just some practice commonly used in CIs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Charlie Chiang charlie_c_0129@outlook.com
Apparently, this workflow is broken:
This is caused by this commit (removed the build commands): 0c33aa3
This pr restores build commands.