Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add arm64 preferences and test coverage #170

Merged
merged 7 commits into from
Jul 12, 2024
Merged

Add arm64 preferences and test coverage #170

merged 7 commits into from
Jul 12, 2024

Conversation

lyarwood
Copy link
Member

@lyarwood lyarwood commented Apr 8, 2024 •
edited
Loading

What this PR does / why we need it:

This PR introduces the following arm64 specific preferences:

  • fedora.arm64
  • rhel.9.arm64

Test coverage is also introduced for using the following preferences with arm64 VirtualMachines as there are no changes required:

  • ubuntu
  • opensuse.leap
  • centos.stream9

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

* `fedora.arm64` and `rhel.9.arm64` preferences have been introduced
* `arm64` test coverage has been extended for the `centos.stream9`,  `ubuntu` and  `opensuse.leap` preferences

@kubevirt-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 8, 2024
0xFelix
0xFelix reviewed Apr 8, 2024
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO we should outline that if not otherwise stated common-instancetypes are implicitly x86? WDYT?

@lyarwood
Copy link
Member Author

lyarwood commented Apr 8, 2024

IMO we should outline that if not otherwise stated common-instancetypes are implicitly x86? WDYT?

Yup I'll document that but most of the instance types should be generic enough to work for both.

@0xFelix
Copy link
Member

0xFelix commented Apr 8, 2024

@lyarwood Right, I meant the preferences of common-instancetypes.

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 20, 2024
@lyarwood lyarwood added this to the v1.1.0 milestone Jun 28, 2024
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 4, 2024
@lyarwood
Copy link
Member Author

lyarwood commented Jul 8, 2024

/test pull-common-instancetypes-kubevirt-functest-fedora-arm64

@kubevirt-bot
Copy link
Contributor

@lyarwood: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-build-common-instancetypes-builder
  • /test pull-common-instancetypes-kubevirt-functest
  • /test pull-common-instancetypes-kubevirt-functest-centos-7
  • /test pull-common-instancetypes-kubevirt-functest-centos-stream-8
  • /test pull-common-instancetypes-kubevirt-functest-centos-stream-9
  • /test pull-common-instancetypes-kubevirt-functest-fedora
  • /test pull-common-instancetypes-kubevirt-functest-opensuse-leap
  • /test pull-common-instancetypes-kubevirt-functest-opensuse-tumbleweed
  • /test pull-common-instancetypes-kubevirt-functest-ubuntu
  • /test pull-common-instancetypes-kubevirt-functest-validation-os

The following commands are available to trigger optional jobs:

  • /test pull-common-instancetypes

Use /test all to run the following jobs that were automatically triggered:

  • pull-common-instancetypes
  • pull-common-instancetypes-kubevirt-functest
  • pull-common-instancetypes-kubevirt-functest-fedora

In response to this:

/test pull-common-instancetypes-kubevirt-functest-fedora-arm64

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lyarwood lyarwood force-pushed the aarch64 branch 3 times, most recently from 84de340 to f7ac9e2 Compare July 10, 2024 10:25
@lyarwood
Copy link
Member Author

/test pull-common-instancetypes-kubevirt-functest-fedora
/test pull-common-instancetypes-kubevirt-functest-fedora-arm64

@lyarwood
Copy link
Member Author

/test pull-common-instancetypes-kubevirt-functest-fedora-arm64

@lyarwood lyarwood mentioned this pull request Jul 10, 2024
Merged
8 tasks
@lyarwood
Copy link
Member Author

/test pull-common-instancetypes-kubevirt-functest-fedora-arm64
/test pull-common-instancetypes-kubevirt-functest-centos-stream-arm64
/test pull-common-instancetypes-kubevirt-functest-opensuse-leap-arm64

@lyarwood
Copy link
Member Author

/test pull-common-instancetypes-kubevirt-functest-ubuntu-arm64

@lyarwood
ubuntu: Add arm64 preference test coverage
6c12a45 
Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
@lyarwood
opensuse.leap: Add arm64 preference test coverage
bad2133 
Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
@lyarwood
fedora: Add arm64 preference
d34f2d9 
Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
@lyarwood
Copy link
Member Author

/test pull-common-instancetypes-kubevirt-functest-ubuntu-arm64

@lyarwood
Copy link
Member Author

/test pull-common-instancetypes-kubevirt-functest-opensuse-leap-arm64

@lyarwood
Copy link
Member Author

/test pull-common-instancetypes-kubevirt-functest-centos-stream-9
/test pull-common-instancetypes-kubevirt-functest-centos-stream-9-arm64

@kubevirt-bot
Copy link
Contributor

@lyarwood: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-build-common-instancetypes-builder
  • /test pull-common-instancetypes-kubevirt-functest
  • /test pull-common-instancetypes-kubevirt-functest-centos-7
  • /test pull-common-instancetypes-kubevirt-functest-centos-stream-8
  • /test pull-common-instancetypes-kubevirt-functest-centos-stream-9
  • /test pull-common-instancetypes-kubevirt-functest-fedora
  • /test pull-common-instancetypes-kubevirt-functest-opensuse-leap
  • /test pull-common-instancetypes-kubevirt-functest-opensuse-tumbleweed
  • /test pull-common-instancetypes-kubevirt-functest-ubuntu
  • /test pull-common-instancetypes-kubevirt-functest-validation-os

The following commands are available to trigger optional jobs:

  • /test pull-common-instancetypes
  • /test pull-common-instancetypes-kubevirt-functest-centos-stream-arm64
  • /test pull-common-instancetypes-kubevirt-functest-fedora-arm64
  • /test pull-common-instancetypes-kubevirt-functest-opensuse-leap-arm64
  • /test pull-common-instancetypes-kubevirt-functest-ubuntu-arm64

Use /test all to run the following jobs that were automatically triggered:

  • pull-common-instancetypes
  • pull-common-instancetypes-kubevirt-functest
  • pull-common-instancetypes-kubevirt-functest-centos-7
  • pull-common-instancetypes-kubevirt-functest-centos-stream-8
  • pull-common-instancetypes-kubevirt-functest-centos-stream-9
  • pull-common-instancetypes-kubevirt-functest-centos-stream-arm64
  • pull-common-instancetypes-kubevirt-functest-fedora
  • pull-common-instancetypes-kubevirt-functest-fedora-arm64
  • pull-common-instancetypes-kubevirt-functest-opensuse-leap
  • pull-common-instancetypes-kubevirt-functest-opensuse-leap-arm64
  • pull-common-instancetypes-kubevirt-functest-opensuse-tumbleweed
  • pull-common-instancetypes-kubevirt-functest-ubuntu
  • pull-common-instancetypes-kubevirt-functest-ubuntu-arm64
  • pull-common-instancetypes-kubevirt-functest-validation-os

In response to this:

/test pull-common-instancetypes-kubevirt-functest-centos-stream-9-arm64

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lyarwood
Copy link
Member Author

/test pull-common-instancetypes-kubevirt-functest-centos-stream-arm64

@lyarwood lyarwood changed the title WIP - Add aarch64 preferences Add arm64 preferences and test coverage Jul 11, 2024
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 11, 2024
@lyarwood lyarwood marked this pull request as ready for review July 11, 2024 10:44
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 11, 2024
@lyarwood
rhel.9: Add arm64 preference
388f204 
This commit also adds some missing functional test coverage for RHEL.
As with the full blown Windows tests these will not run upstream.

Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
@lyarwood
centos.stream9: Add arm64 preference test coverage
16ff107 
Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
0xFelix
0xFelix approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Thanks!

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2024
@kubevirt-bot kubevirt-bot merged commit e9693b5 into kubevirt:main Jul 12, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFelix 0xFelix 0xFelix approved these changes

@akrejcir akrejcir Awaiting requested review from akrejcir

@codingben codingben Awaiting requested review from codingben

Assignees

@0xFelix 0xFelix

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lyarwood @kubevirt-bot @0xFelix