Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common-instancetypes: Add remaining arm64 presubmits #3519

Conversation

lyarwood
Copy link
Member

What this PR does / why we need it:

This adds the remaining (for now) arm64 presubmits for common-instancetypes in support of kubevirt/common-instancetypes#170.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:

NONE

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Jul 10, 2024
…-centos-stream-arm64

Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
…-ubuntu-arm64

Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
…-opensuse-leap-arm64

Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
@lyarwood lyarwood force-pushed the common-instancetypes-add-remaining-arm64-presubmits branch from 31b0404 to 98c0c5f Compare July 10, 2024 13:13
@@ -267,6 +267,56 @@ presubmits:
privileged: true
nodeSelector:
type: bare-metal-external
- name: pull-common-instancetypes-kubevirt-functest-centos-stream-arm64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: pull-common-instancetypes-kubevirt-functest-centos-stream-arm64
- name: pull-common-instancetypes-kubevirt-functest-centos-stream-9-arm64

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You likely missed this but CI was failing given the length of this name:

https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_project-infra/3519/check-prow-config/1811025451057942528

{"component":"checkconfig","file":"sigs.k8s.io/prow/cmd/checkconfig/main.go:91","func":"main.reportWarning","level":"warning","msg":"name of Presubmit job \"pull-common-instancetypes-kubevirt-functest-centos-stream-9-arm64\" (for repo \"kubevirt/common-instancetypes\") too long (should be at most 63 characters)","severity":"warning","time":"2024-07-10T13:11:40Z"}

Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2024
@kubevirt-bot kubevirt-bot merged commit c64ba36 into kubevirt:main Jul 10, 2024
5 checks passed
@kubevirt-bot
Copy link
Contributor

@lyarwood: Updated the job-config configmap in namespace kubevirt-prow at cluster default using the following files:

  • key common-instancetypes-presubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/common-instancetypes/common-instancetypes-presubmits.yaml

In response to this:

What this PR does / why we need it:

This adds the remaining (for now) arm64 presubmits for common-instancetypes in support of kubevirt/common-instancetypes#170.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants