-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
common-instancetypes: Add remaining arm64 presubmits #3519
common-instancetypes: Add remaining arm64 presubmits #3519
Conversation
…-centos-stream-arm64 Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
…-ubuntu-arm64 Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
…-opensuse-leap-arm64 Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
31b0404
to
98c0c5f
Compare
@@ -267,6 +267,56 @@ presubmits: | |||
privileged: true | |||
nodeSelector: | |||
type: bare-metal-external | |||
- name: pull-common-instancetypes-kubevirt-functest-centos-stream-arm64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- name: pull-common-instancetypes-kubevirt-functest-centos-stream-arm64 | |
- name: pull-common-instancetypes-kubevirt-functest-centos-stream-9-arm64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You likely missed this but CI was failing given the length of this name:
{"component":"checkconfig","file":"sigs.k8s.io/prow/cmd/checkconfig/main.go:91","func":"main.reportWarning","level":"warning","msg":"name of Presubmit job \"pull-common-instancetypes-kubevirt-functest-centos-stream-9-arm64\" (for repo \"kubevirt/common-instancetypes\") too long (should be at most 63 characters)","severity":"warning","time":"2024-07-10T13:11:40Z"}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0xFelix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@lyarwood: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
This adds the remaining (for now) arm64 presubmits for common-instancetypes in support of kubevirt/common-instancetypes#170.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note: