[release-v1.59] Progress metrics refactor and rename #3270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
release-note
Manual backport of kubevirt#3254 clone_progress, openstack_populator_progress and ovirt_progress metrics are not in the monitoring package. These metrics are not with correct metrics names, based on the kubevirt and Prometheus metrics naming conventions, they are not documented and are not located under /pkg/monitoring. After the code refactoring we should not have Prometheus metrics in other places in the code, other than the /monitoring/metrics package, and metrics should be registered using operator-observability package. In addition, we aligned the progress metric names with the metric naming linter rules: kubevirt_cdi_clone_progress_total kubevirt_cdi_openstack_populator_progress_total kubevirt_cdi_ovirt_progress_total Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
arnongilboa
force-pushed
the
clone_progress_metric_refactor-v1.59
branch
from
bfe42fc to
1304ee8
Compare
|
/test pull-containerized-data-importer-e2e-destructive-release |
kubevirt-bot
added
the
do-not-merge/hold
Manual backport of kubevirt#3292 Use default metric registration. We shouldn't use the controller-runtime registration as we have no controller here and it will not register the metric correctly. Add kubevirt_cdi_import_progress_total metric and use it in the importer instead of kubevirt_cdi_clone_progress_total. Fix the metric parsing to match their new names. Otherwise the DV progress will not be updated until its 100%. Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
Backport of kubevirt#3293 * tests: fix regex in import progress test This test currently passes since the regex will always catch 100%, hiding a bug we have in progress reporting. Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com> * Fix actual progress reporting for url->scratch Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com> * Hold on with reporting 100% until pod exits Otherwise, we'll be reporting 100% prior to convert/resize/... being done Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com> * tests: fix a test that was adapted to no progress reporting this tests cares about some progress being made so N/A isn't the right choice Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com> --------- Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akalenyu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
/hold cancel |
kubevirt-bot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Manual backport of #3254, #3292, #3293
clone_progress,openstack_populator_progressandovirt_progressmetrics are not in the monitoring package. These metrics are not with correct metrics names, based on the kubevirt and Prometheus metrics naming conventions, they are not documented and are not located under/pkg/monitoring. After the code refactoring we should not have Prometheus metrics in other places in the code, other than the/monitoring/metricspackage, and metrics should be registered usingoperator-observabilitypackage.Align the progress metric names with the metric naming linter rules:
kubevirt_cdi_clone_progress_total,kubevirt_cdi_openstack_populator_progress_total,kubevirt_cdi_ovirt_progress_total. Addkubevirt_cdi_import_progress_totalmetric and use it in the importer instead ofkubevirt_cdi_clone_progress_total.Fix the metric parsing to match their new names. Otherwise the DV progress will not be updated until its 100%.
Fix progress reporting for http imports.
Which issue(s) this PR fixes:
Fixes #https://issues.redhat.com/browse/CNV-36845
Special notes for your reviewer:
Release note: