Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v1.59] Revert LVMO storage CSI snapshot clone. #3304

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

awels
Copy link
Member

@awels awels commented Jun 4, 2024

What this PR does / why we need it:
On multi node LMVO this setting can cause issues so reverting to host assisted clone which works everywhere

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes https://issues.redhat.com/browse/CNV-41081

Special notes for your reviewer:

Release note:

NONE

On multi node LMVO this setting can cause issues
so reverting to host assisted clone which works
everywhere

Signed-off-by: Alexander Wels <awels@redhat.com>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jun 4, 2024
@kubevirt-bot kubevirt-bot requested review from aglitke and mhenriks June 4, 2024 19:23
@awels awels changed the title Revert LVMO storage CSI snapshot clone. (#3303) [release-v1.59] Revert LVMO storage CSI snapshot clone. Jun 4, 2024
@awels
Copy link
Member Author

awels commented Jun 4, 2024

/hold

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 4, 2024
@akalenyu
Copy link
Collaborator

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2024
@akalenyu
Copy link
Collaborator

/hold cancel

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akalenyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 10, 2024
@kubevirt-bot kubevirt-bot merged commit 86eb720 into kubevirt:release-v1.59 Jul 10, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants