Adding Apple to list of adopters #794
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Callegari <mazzystr@gmail.com>
kubevirt-bot
added
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
We can't. All the icons are governed by corporate legal/marketing.
They're giving me the exact size in px on how they want the logo displayed.
…On Tue, Sep 7, 2021 at 7:38 PM Tyler Auerbeck ***@***.***> wrote:
***@***.**** commented on this pull request.
LGTM. Only thing I'd mention (and maybe something to look into in the
future) would be normalizing the icon sizes. Right now they look a bit all
over the place.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#794 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAS5KZZORB6MZG6S6A6RD2TUA3EEDANCNFSM5DS7QCDQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
Preview link is here .... https://deploy-preview-794--kubevirtio.netlify.app/ |
|
@mazzystr: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
kubevirt-bot
added
the
needs-rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chris Callegari mazzystr@gmail.com
Fixes #782
Special notes for your reviewer:
@mlsorensen