Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding arm to index page as end-user per KubeVirt ADOPTERS #815

Merged
merged 1 commit into from
Nov 9, 2021

Conversation

mazzystr
Copy link
Contributor

@mazzystr mazzystr commented Nov 4, 2021

/kind enhancement
/label website

What this PR does / why we need it:
Adding arm to index page as end-user per KubeVirt ADOPTERS

Fixes #812

Signed-off-by: Chris Callegari <mazzystr@gmail.com>
@kubevirt-bot kubevirt-bot added kind/enhancement dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Nov 4, 2021
@kubevirt-bot
Copy link
Contributor

@mazzystr: The label(s) `/label website

` cannot be applied. These labels are supported: ``

In response to this:

/kind enhancement
/label website

What this PR does / why we need it:
Adding arm to index page as end-user per KubeVirt ADOPTERS

Fixes #812

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot added kind/website Label for web site management/maintenance/... size/M labels Nov 4, 2021
@mazzystr
Copy link
Contributor Author

mazzystr commented Nov 4, 2021

@zhlhahaha Url for review for logo use compliance is here .... https://deploy-preview-815--kubevirtio.netlify.app/

Please comment lgtm and approve.

Then I will have a maintainer add the merge tag. Thanks!

@zhlhahaha
Copy link

@zhlhahaha Url for review for logo use compliance is here .... https://deploy-preview-815--kubevirtio.netlify.app/

Please comment lgtm and approve.

Then I will have a maintainer add the merge tag. Thanks!

Ok, would it be better to put the source of Arm logo in the comments?

@mazzystr
Copy link
Contributor Author

mazzystr commented Nov 8, 2021 via email

@zhlhahaha
Copy link

Ok,
/approve
/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 9, 2021
@mazzystr
Copy link
Contributor Author

mazzystr commented Nov 9, 2021 via email

@kubevirt-bot
Copy link
Contributor

@mazzystr: you cannot LGTM your own PR.

In response to this:

Thank you!

/lgtm
/approve

On Mon, Nov 8, 2021, 5:25 PM kubevirt-bot @.***> wrote:

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zhlhahaha
#815 (comment)

To complete the pull request process
https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process,
please ask for approval from mazzystr after the PR has been reviewed.

The full list of commands accepted by this bot can be found here
https://go.k8s.io/bot-commands?repo=kubevirt%2Fkubevirt.github.io.
Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#815 (comment),
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAS5KZ3LSNBBBHJUP4247OTULBZ67ANCNFSM5HMSWK4Q
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mazzystr, zhlhahaha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2021
@kubevirt-bot kubevirt-bot merged commit 1723d9a into kubevirt:master Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/enhancement kind/website Label for web site management/maintenance/... lgtm Indicates that a PR is ready to be merged. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Obtain permission to advertise ARM on index page
3 participants