[release-1.2] monitoring: Fix wrong calculation for KubeVirtVMIExcessiveMigrations in an edge case
#12358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in an edge case There is an edge case, usually during an upgrade, in which two or more different virt-controllers are reporting the 'kubevirt_vmi_migration_succeeded' metric for the same migration (VMIM) on the same VMI. In that case, we need to count that migration only once regardless of it being reported multiple times for the purpose of firing the alert about excessive amount of migrations in the last 24 hours. The new PromQL isolates the entries with different VMIMs, then sets the value of '1' to all of them, and then we're summing by the pair of vmi and its namespace. Signed-off-by: Oren Cohen <ocohen@redhat.com>
8 tasks
kubevirt-bot
added
release-note
kubevirt-bot
added
sig/buildsystem
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enp0s3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
/retest |
|
/lgtm |
|
/retest-required |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #12209
/assign orenc1