Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bootstrap files: Add bind-utils #2501

Merged
merged 1 commit into from
Dec 5, 2022
Merged

bootstrap files: Add bind-utils #2501

merged 1 commit into from
Dec 5, 2022

Conversation

oshoval
Copy link
Contributor

@oshoval oshoval commented Dec 5, 2022 •
edited
Loading

Needed for nslookup which is used by KubeSecondaryDNS.

Signed-off-by: Or Shoval oshoval@redhat.com

@oshoval
bootstrap files: Add bind-utils
b480fae 
Needed for nslookup which is used by
KubeSecondaryDNS.

Signed-off-by: Or Shoval <oshoval@redhat.com>
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Dec 5, 2022
@oshoval
Copy link
Contributor Author

oshoval commented Dec 5, 2022

/cc @brianmcarey @AlonaKaplan

@oshoval oshoval mentioned this pull request Dec 5, 2022
Merged
@oshoval
Copy link
Contributor Author

oshoval commented Dec 5, 2022 •
edited
Loading

/retest

I wonder what is this error 137
https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_project-infra/2501/build-bootstrap-image/1599700104095207424

OOM ?

@oshoval
Copy link
Contributor Author

oshoval commented Dec 5, 2022 •
edited
Loading

/retest

@brianmcarey
I think we might need more memory for the job ?

build-bootstrap-image and build-bootstrap-legacy-images

@oshoval oshoval mentioned this pull request Dec 5, 2022
Closed
@brianmcarey
Copy link
Member

/retest

@brianmcarey I think we might need more memory for the job ?

build-bootstrap-image and build-bootstrap-legacy-images

It doesn't look like a memory issue from looking at the pod metrics but maybe there is another job on the node taking more memory than requested.

Screenshot from 2022-12-05 13-42-14

I would try another retest and then we can look at increasing the memory request/limit.

@oshoval
Copy link
Contributor Author

oshoval commented Dec 5, 2022 •
edited
Loading

thanks, i see a line is running now, lets see that status / retest if needed
the build-bootstrap-image had it as well and now is passed

just some CI jobs on other PRs that say there was no memory, but maybe was transient
kubevirt/kubesecondarydns#40 (comment)

@oshoval
Copy link
Contributor Author

oshoval commented Dec 5, 2022

failed here

https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_project-infra/2501/build-bootstrap-legacy-images/1599761098167291904#1:build-log.txt%3A1950

/retest

brianmcarey added a commit to brianmcarey/project-infra that referenced this pull request Dec 5, 2022
@brianmcarey
Increase memory requests of bootstrap image build jobs
b06aa26 
The presubmit jobs which test the building of the bootstrap container
images look to be failing due to low memory.

kubevirt#2501

Signed-off-by: Brian Carey <bcarey@redhat.com>
@brianmcarey brianmcarey mentioned this pull request Dec 5, 2022
Merged
kubevirt-bot pushed a commit that referenced this pull request Dec 5, 2022
@brianmcarey
Increase memory requests of bootstrap image build jobs (#2503)
d99c20c 
The presubmit jobs which test the building of the bootstrap container
images look to be failing due to low memory.

#2501

Signed-off-by: Brian Carey <bcarey@redhat.com>

Signed-off-by: Brian Carey <bcarey@redhat.com>
@dhiller
Copy link
Contributor

dhiller commented Dec 5, 2022

/retest

dhiller
dhiller reviewed Dec 5, 2022
View reviewed changes
Copy link
Contributor

@dhiller dhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/hold since the build job is not required, PTAL and remove the hold if it works

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2022
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhiller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2022
brianmcarey
brianmcarey reviewed Dec 5, 2022
View reviewed changes
Copy link
Member

@brianmcarey brianmcarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2022
@brianmcarey
Copy link
Member

Build passed successfully - https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_project-infra/2501/build-bootstrap-legacy-images/1599789686539161600

/unhold

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2022
@kubevirt-bot kubevirt-bot merged commit e30b34a into kubevirt:main Dec 5, 2022
@oshoval
Copy link
Contributor Author

oshoval commented Dec 6, 2022

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianmcarey brianmcarey brianmcarey left review comments

@dhiller dhiller dhiller left review comments

@phoracek phoracek Awaiting requested review from phoracek

@AlonaKaplan AlonaKaplan Awaiting requested review from AlonaKaplan

Assignees

@brianmcarey brianmcarey

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oshoval @brianmcarey @dhiller @kubevirt-bot