Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubevirtci, crio: Fix crio mirror by adding gcloud to PATH #3391

Merged
merged 1 commit into from
May 2, 2024

Conversation

brianmcarey
Copy link
Member

What this PR does / why we need it:

gcloud is no longer added to PATH by default. This change adds gcloud to PATH which allows the job to complete sccessfully[1].

[1] https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/logs/periodic-kubevirtci-mirror-crio-repository-weekly/1785980497139077120

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

/cc @dhiller

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:


gcloud is no longer added to PATH by default. This change adds gcloud to
PATH which allows the job to complete sccessfully[1].

[1] https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/logs/periodic-kubevirtci-mirror-crio-repository-weekly/1785980497139077120

Signed-off-by: Brian Carey <bcarey@redhat.com>
@kubevirt-bot kubevirt-bot requested a review from dhiller May 2, 2024 12:16
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XS labels May 2, 2024
Copy link
Contributor

@dhiller dhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thanks @brianmcarey !

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 2, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhiller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2024
@kubevirt-bot kubevirt-bot merged commit 3a55b8d into kubevirt:main May 2, 2024
5 checks passed
@kubevirt-bot
Copy link
Contributor

@brianmcarey: Updated the job-config configmap in namespace kubevirt-prow at cluster default using the following files:

  • key kubevirtci-periodics.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/kubevirtci/kubevirtci-periodics.yaml

In response to this:

What this PR does / why we need it:

gcloud is no longer added to PATH by default. This change adds gcloud to PATH which allows the job to complete sccessfully[1].

[1] https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/logs/periodic-kubevirtci-mirror-crio-repository-weekly/1785980497139077120

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

/cc @dhiller

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

brianmcarey added a commit to brianmcarey/project-infra that referenced this pull request May 13, 2024
The periodic job that updates the istio mirror is failing due to being
unable to find the gcloud command[1]. Adding gcloud to PATH should fix this
issue.

This is a similar change to what was done for the cri-o mirror job[2]

[1] https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/logs/periodic-project-infra-mirror-istioctl/1789829270676180992#1:build-log.txt%3A93
[2] kubevirt#3391

Signed-off-by: Brian Carey <bcarey@redhat.com>
kubevirt-bot pushed a commit that referenced this pull request May 13, 2024
The periodic job that updates the istio mirror is failing due to being
unable to find the gcloud command[1]. Adding gcloud to PATH should fix this
issue.

This is a similar change to what was done for the cri-o mirror job[2]

[1] https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/logs/periodic-project-infra-mirror-istioctl/1789829270676180992#1:build-log.txt%3A93
[2] #3391

Signed-off-by: Brian Carey <bcarey@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants