Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap: Ignore podman warning for deprecation of cgroups v1 #3485

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

brianmcarey
Copy link
Member

What this PR does / why we need it:

Both the control plane cluster and workloads cluster are running with cgroups v1.

Since Podman v5, warning messages have started to appear in jobs logs[1]

Add environment variable to ignore these warnings and reduce noise in job logs.

[1] https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/12196/pull-kubevirt-e2e-k8s-1.29-sig-compute/1805168405502758912#1:build-log.txt%3A323

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:
/cc @dhiller @xpivarc

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:


Both the control plane cluster and workloads cluster are running with
cgroups v1.

Since Podman v5, warning messages have started to appear in jobs logs[1]

Add environment variable to ignore these warnings and reduce noise in
job logs.

[1] https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/12196/pull-kubevirt-e2e-k8s-1.29-sig-compute/1805168405502758912#1:build-log.txt%3A323

Signed-off-by: Brian Carey <bcarey@redhat.com>
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XS labels Jun 24, 2024
Copy link
Contributor

@dhiller dhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brianmcarey while I do agree that we should unclutter the log file, I think we should create a cgroups v2 migration story - maybe I am overlooking an already existing one?

/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhiller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2024
@kubevirt-bot kubevirt-bot merged commit c896e49 into kubevirt:main Jun 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants