Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sig-ci: add label for sig #3518

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Conversation

dhiller
Copy link
Contributor

@dhiller dhiller commented Jul 10, 2024

What this PR does / why we need it:

We want to have a label sig/ci that we can apply whenever we create issues i.e. from the sig-ci weekly or sig-ci tests quarantine meetings. This way we can find the issues that are our responsibility better.

Note: in the same way labels are added (automatically via OWNERS files) for kubevirt/kubevirt).

This PR adds a label to use for sig CI.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Currently we can't use the label for marking issues 1

Special notes for your reviewer:
/cc @brianmcarey @xpivarc

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:


@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XS labels Jul 10, 2024
Signed-off-by: Daniel Hiller <dhiller@redhat.com>
Copy link
Member

@brianmcarey brianmcarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brianmcarey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2024
@kubevirt-bot kubevirt-bot merged commit aac5ecb into kubevirt:main Jul 11, 2024
6 checks passed
@kubevirt-bot
Copy link
Contributor

@dhiller: Updated the label-config configmap in namespace kubevirt-prow at cluster default using the following files:

  • key labels.yaml using file github/ci/prow-deploy/kustom/base/configs/current/labels/labels.yaml

In response to this:

What this PR does / why we need it:

We want to have a label sig/ci that we can apply whenever we create issues i.e. from the sig-ci weekly or sig-ci tests quarantine meetings. This way we can find the issues that are our responsibility better.

Note: in the same way labels are added (automatically via OWNERS files) for kubevirt/kubevirt).

This PR adds a label to use for sig CI.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Currently we can't use the label for marking issues 1

Special notes for your reviewer:
/cc @brianmcarey @xpivarc

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants