Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v0.20] common instancetypes: Deprecate operand #993

Conversation

lyarwood
Copy link
Member

What this PR does / why we need it:

Manual backport of #986 (kubevirt-bot dead?)

Deployment of the common-instancetypes resources will be handled by virt-operator moving forward so we can finally deprecate the operand within SSP for removal in a future release.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Release note:

Deployment of `common-instancetypes` using this operator is now deprecated and will be removed in a future release.

lyarwood added 3 commits June 10, 2024 10:14
Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
(cherry picked from commit 9397766)
Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
(cherry picked from commit 719e9e2)
Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
(cherry picked from commit b72a05b)
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jun 10, 2024
@lyarwood
Copy link
Member Author

/cc @0xFelix
/cc @akrejcir

Copy link

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.1% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2024
@lyarwood
Copy link
Member Author

/hold

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 10, 2024
@lyarwood
Copy link
Member Author

/hold cancel

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 10, 2024
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2024
@kubevirt-bot kubevirt-bot merged commit cf84347 into kubevirt:release-v0.20 Jul 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants