Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

At least to me the networking documentation is hard to follow #91

Closed
rmohr opened this issue Jun 21, 2018 · 5 comments
Closed

At least to me the networking documentation is hard to follow #91

rmohr opened this issue Jun 21, 2018 · 5 comments
Assignees
Labels

Comments

@rmohr
Copy link
Member

rmohr commented Jun 21, 2018

Can we follow a little bit more the structure like we have for https://kubevirt.io/user-guide/#/workloads/virtual-machines/disks-and-volumes? The structure there is lent from k8s, which I personally find pretty easy to follow and user-focused.

So to have

  • Examples per configs
  • For instance also show where and how to set the model
  • For a comprehensive and up-to-date list of supported values, link to the api-reference and make sure that the api-reference comment contains supported values.

It may just be me, but I find the structure of this document very confusing and it is almost impossible for me to parse it and extract the necessary information. It also looks a little bit like this documentation tries to be a mixture of api-reference and user-guide. We should leverage the fact that we have an api-reference.

from #89 (comment)

@fabiand
Copy link
Member

fabiand commented Jun 21, 2018

I totally agree. The networking do is structural wise not so good.

Technically the problem s that we have three components: frontend, connection, backend.

This makes the current situation so bad.

But we can probably flatten this by mentioning the relevant connection times in the context of frontend, then we again only have frontends and backends, which should allow us to follow the disk pattern.

My 2ct

@fabiand fabiand added the bug label Jun 21, 2018
@booxter
Copy link
Contributor

booxter commented Jun 21, 2018

@rmohr Agreed. About examples, how do we guarantee they are valid / still working as we move forward? Maybe we could consume them from kubevirt repo (cluster/examples/?) and allow validations to happen against each of examples. What do you think?

@fabiand
Copy link
Member

fabiand commented Jun 21, 2018

Maybe we could consume them from kubevirt repo (cluster/examples/?) and allow validations to happen against each of examples. What do you think?

Technically this works with docsify.

An exampe is here:
#92

Gotot th evirtual machines section to see bar and an inline external yaml file.

@rmohr
Copy link
Member Author

rmohr commented Jun 21, 2018

@rmohr Agreed. About examples, how do we guarantee they are valid / still working as we move forward? Maybe we could consume them from kubevirt repo (cluster/examples/?) and allow validations to happen against each of examples. What do you think?

Anything that helps to keep them valid is great. I did not have a clear picture in my mind on how to do that. If you have ideas go ahead! 👍

@booxter
Copy link
Contributor

booxter commented Jun 21, 2018

Please assign me to the issue (or give me access to the action). I will look into this during / after macAddress work.

@vladikr vladikr assigned vladikr and booxter and unassigned vladikr Jun 21, 2018
booxter added a commit to booxter/user-guide that referenced this issue Jun 27, 2018
The page was not in line with the rest of documentation, had multiple bugs,
incorrect information, typos, grammar issues.

This patch reworks the structure and contents of the page from the ground up,
with the emphasis on providing timely examples and capturing just the features
that are already implemented.

Fixes kubevirt#91
booxter added a commit to booxter/user-guide that referenced this issue Jul 3, 2018
The page was not in line with the rest of documentation, had multiple bugs,
incorrect information, typos, grammar issues.

This patch reworks the structure and contents of the page from the ground up,
with the emphasis on providing timely examples and capturing just the features
that are already implemented.

Fixes kubevirt#91
booxter added a commit to booxter/user-guide that referenced this issue Jul 5, 2018
The page was not in line with the rest of documentation, had multiple bugs,
incorrect information, typos, grammar issues.

This patch reworks the structure and contents of the page from the ground up,
with the emphasis on providing timely examples and capturing just the features
that are already implemented.

Fixes kubevirt#91
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants