Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POC] Inline external #92

Closed
wants to merge 2 commits into from
Closed

Conversation

fabiand
Copy link
Member

@fabiand fabiand commented Jun 21, 2018

This is an example how an external file can be inlined:

Can be previewed here:
https://fabiand.github.io/user-guide/#/workloads/virtual-machines/README

Described here:
https://docsify.js.org/#/embed-files

Relates to #91 (comment)

f
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
f
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
@fabiand
Copy link
Member Author

fabiand commented Jun 21, 2018

@booxter fyi

@booxter
Copy link
Contributor

booxter commented Jul 11, 2018

I am now not sure inlining would be helpful. It would mean that we need to inline complete examples into docs. The examples may be quite long and loose the right focus on specific field described in a particular place of the document.

@fabiand
Copy link
Member Author

fabiand commented Jul 11, 2018

That's true - good perspective on the matter.

Well - maybe they can extend each other: Shortened snippets (extensive use of ellipsis) and links to working exampples (which live in the kubevirt repo).

But this means that this issue is not needed.

@fabiand fabiand closed this Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants