Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document parameter value types #215

Merged
merged 1 commit into from
Mar 18, 2020
Merged

Document parameter value types #215

merged 1 commit into from
Mar 18, 2020

Conversation

nfnt
Copy link
Member

@nfnt nfnt commented Mar 5, 2020

What this PR does / why we need it:
Documents parameter value types introduced in kudobuilder/kudo#1376

Document parameter value types
2b12258 
Signed-off-by: Jan Schlicht <jan@d2iq.com>
@nfnt nfnt requested a review from meichstedt as a code owner March 5, 2020 10:38
@nfnt nfnt self-assigned this Mar 5, 2020
kensipe
kensipe requested changes Mar 5, 2020
View reviewed changes
Copy link
Member

@kensipe kensipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be against the next-release branch

@kensipe kensipe self-requested a review March 13, 2020 14:24
porridge
porridge approved these changes Mar 18, 2020
View reviewed changes
Copy link
Member

@porridge porridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed this PR literally 1 minute after having merged the next-release branch.
Now that the release had happened, I think we should merge straight to master. Leaving it up to @kensipe to push the button, LGTM to me.

@porridge porridge mentioned this pull request Mar 18, 2020
Closed
@meichstedt meichstedt merged commit 068b21c into master Mar 18, 2020
@meichstedt meichstedt deleted the nfnt/typed-param-values branch March 18, 2020 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@porridge porridge porridge approved these changes

@meichstedt meichstedt meichstedt approved these changes

@kensipe kensipe Awaiting requested review from kensipe

Assignees

@nfnt nfnt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nfnt @kensipe @meichstedt @porridge