Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interfaces refactoring #251

Merged
merged 4 commits into from
Jul 26, 2020
Merged

interfaces refactoring #251

merged 4 commits into from
Jul 26, 2020

Conversation

kukhariev
Copy link
Owner

@kukhariev kukhariev commented Jul 21, 2020

BREAKING CHANGE: Rename RequestParams to RequestOptions
BREAKING CHANGE: Removed *All from UploadAction
BREAKING CHANGE: Strongly typed response body

BREAKING CHANGE: Rename RequestParams to RequestOptions
@kukhariev kukhariev changed the title refactor: remove RequestParams type interfaces refactoring Jul 22, 2020
BREAKING CHANGE: Removed `*All` from UploadAction
BREAKING CHANGE: Strongly typed response body
@todo
Copy link

todo bot commented Jul 24, 2020

check null body status

// TODO: check null body status
this.response = this.responseStatus !== 204 ? this.getResponseBody(xhr) : '';
this.responseStatus >= 400 ? reject(evt) : resolve(evt);
};


This comment was generated by todo based on a TODO comment in 8e600dc in #251. cc @kukhariev.

@kukhariev kukhariev merged commit 8bfaa1c into master Jul 26, 2020
@todo todo bot mentioned this pull request Jul 26, 2020
@kukhariev kukhariev deleted the interfaces-refactor branch July 30, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant