[pull] master from angular:master #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
_compile_action should take a list since we compute it within one node in the build graph This needs to be cleaned up since Bazel is getting stricter with disallowing iteration over depsets PR Close #30600
#30597) Currently the `@angular/compiler-cli` compliance tests sometimes do not throw an exception if the expected output does not match the generated JavaScript output. This can happen for the following cases: 1. Expected code includes character that is not part of known alphabet (e.g. `Δ` is still used in a new compliance test after rebasing a PR) 2. Expected code asserts that a string literal matches a string with escaped quotes. e.g. expects `const $var$ = "\"quoted\"";`) PR Close #30597
Prior to this change we processed binding expression (including bindings with pipes) in i18n attributes before we generate update instruction. As a result, slot offsets for pipeBind instructions were calculated incorrectly. Now we perform binding expression processing when we generate "update block" instructions, so offsets are calculated correctly. PR Close #30573
The AbsoluteModuleStrategy in ngtsc assumed that the source code is formatted as TypeScript with regards to module exports. In ngcc this is not always the case, so this commit changes `AbsoluteModuleStrategy` so that it relies upon a `ReflectionHost` to compute the exports of a module. PR Close #30200
…0611) With Ivy, injecting a `ViewContainerRef` for a `<ng-container>` element results in two comments generated in the DOM. One comment as host element for the `ElementContainer` and one for the generated `LContainer` which is needed for the created `ViewContainerRef`. This is problematic as developers expect the same anchor element for the `LContainer` and the `ElementContainer` in order to be able to move the host element of `<ng-container>` without leaving the actual `LContainer` anchor element at the original location. This worked differently in View Engine and various applications might depend on the behavior where the `ViewContainerRef` shares the anchor comment node with the host comment node of the `<ng-container>`. For example `CdkTable` from `@angular/cdk` moves around the host element of a `<ng-container>` and also expects embedded views to be inserted next to the moved `<ng-container>` host element. See: https://github.com/angular/components/blob/f8be5329f8d94128ece5dfe3e8e998fe4077d44d/src/cdk/table/table.ts#L999-L1016 Resolves FW-1341 PR Close #30611
…ring (#30602) Prior to this change a component was considered unresolved (i.e. having dynamic resources that should be loaded, like external template or stylesheets) even if template override was provided as an empty string (for example, via TestBed.overrideTemplateUsingTestingModule call). This commit fixes the condition that previously treated empty string as an absent template value. PR Close #30602
- adds the ɵɵattribute instruction - adds compilation handling for Δattribute instruction - updates tests PR Close #30503
…ws (#30979) When using `createEmbeddedView` after the creation of an ICU expression, the nodes for the current selected case were not reprojected (only the anchor comment node was moved to the new location). Now we reproject correctly all the child nodes of an ICU expression when an anchor comment node is projected. FW-1372 #resolve PR Close #30979
i18nExp now uses `bind` internally rather than having the compiler generate it in order to bring it in line with other functions like `textBinding` & `property`. FW-1384 #resolve PR Close #31089
Currently when building the `ts-api-guardian` npm package, the labels are not properly replaced after recent changes to the `entry_point` attribute. This means that the `ts-api-guardian` package is currently not usable externally. PR Close #31096
) Updating [angular#master](https://github.com/angular/angular/tree/master) from [cli-builds#master](https://github.com/angular/cli-builds/tree/master). ## Relevant changes in [commit range](angular/cli-builds@032be4e...ab6f362): **Modified** - help/doc.json ## PR Close #31102
* Updates buildifier to a version that also comes with windows binaries. * Fixes a few new formatting/lint warnings * Removes the `args-order` warning because it is no longer a warning.. and is now part of the formatter. PR Close #31112
docs: add core and cli version alignment note PR Close #30976
) Previously, our auto-linking feature would match `http` in URLs (such as `http://...`) to the `common/http` package and automatically create a link to that, which was undesirable. While it is possible to work around that via `<code class="no-auto-link">http://...</code>`, most people didn't even realize the issue. Since in this case it is possible to reliably know it is a false match, this commit fixes it by applying a custom auto-link filter that ignores all docs for `http`, if it comes before `://`. Fixes #31012 PR Close #31051
``` NgLSHost: AngularLanguageServiceHost NgLS: AngularLanguageService ``` NgLSHost should not depend on NgLS, because it introduces circular dependency. Instead, the `getTemplateAst` and `getTemplatAstAtPosition` methods should be moved to NgLSHost and exposed as public methods. This removes the circular dependency, and also removes the need for the awkward 'setSite' method in NgLSHost. PR Close #31122
Currently each property binding generates an instruction like this:
```
property('prop1', ctx.value1);
property('prop2', ctx.value2);
```
The problem is that we're repeating the call to `property` for each of the properties. Since the `property` instruction returns itself, we can chain all of the calls which is more compact and it looks like this:
```
property('prop1', ctx.value1)('prop2', ctx.value2);
```
These changes implement the chaining behavior for regular property bindings and for synthetic ones, however interpolated ones are still handled like before, because they use a separate instruction.
This PR resolves FW-1389.
PR Close #31078
Currently the `placeholders` parameter inside `i18nLocalize` is defaulted to `{}`, which means that we'll always hit the `Object.keys` call below. Since it's very likely that we won't have placeholders in the majority of strings, these changes add an extra guard so that we don't hit it on every invocation.
PR Close #31106
PR Close #31115
PR Close #31115
Payload size tracking was temporarily disabled in #31057, due to `CIRCLE_COMPARE_URL` stopping being available. It turned out this was related to turning on the new [Pipelines][1] feature, which was required for testing Windows on CircleCI. Since then, we have turned `Pipelines` off and got `CIRCLE_COMPARE_URL` back (e.g. see [build 362971][2]). According to CircleCI, failing to populate `CIRCLE_COMPARE_URL` with `Pipelines` on is a bug and they are working on fixing it. [1]: https://circleci.com/docs/2.0/build-processing/ [2]: https://circleci.com/gh/angular/angular/362971 Fixes #31121 PR Close #31138
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]. Want to support this open source service? Please star it : )