Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): 23.10.4 #795

Merged
merged 1 commit into from
Oct 6, 2018
Merged

chore(release): 23.10.4 #795

merged 1 commit into from
Oct 6, 2018

Conversation

huafu
Copy link
Collaborator

@huafu huafu commented Oct 6, 2018

23.10.4 (2018-10-06)

Bug Fixes

  • cache: adds project's dep versions to cache key (6cacbea), closes #785
  • cli: change options to better reflect the new presets (68abcfb)
  • helpers: deprecate import from ts-jest, now ts-jest/utils (33ff29f), closes #782
  • typings: typo in presets definition file (53767ab)
  • typings: wrong import in preset typings + test (94dc4e7)

@huafu huafu added the release label Oct 6, 2018
@huafu huafu added this to the 23.10.4 milestone Oct 6, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1982

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.919%

Totals Coverage Status
Change from base Build 1979: 0.0%
Covered Lines: 1088
Relevant Lines: 1138

💛 - Coveralls

@GeeWee
Copy link
Collaborator

GeeWee commented Oct 6, 2018

I think we should put deprecations in a minor release.

@huafu
Copy link
Collaborator Author

huafu commented Oct 6, 2018

@GeeWee what you meant by deprecations?

Here is what happened:

to fix #782 we needed to move helpers (of ts-jest) meant to be used in users test files out of the whole ts-jest dist, so that it could be imported the same way, whatever the user would have set in tsconfig that could affect importing strategy (esModuleInterop, allowSyntheticDefaultImports, ...).

Knowing that, it would not make sense to keep the helpers in 2 spots. So I've moved:

  • presets into ts-jest/presets
  • utils into ts-jest/utils

...and ensured they were not doing any import that would end-up in an incompatible import (depending on users config)

To NOT make this a breaking change, using old helpers will map to new ones but also log some warnings (without throwing), so that the users have the ability to change their call thanks to the log message, while not breaking their tests.

We can then totally remove old helpers in a future, non patch release.

@GeeWee
Copy link
Collaborator

GeeWee commented Oct 6, 2018

Yeah fair enough.

@huafu huafu merged commit ef89ee6 into kulshekhar:master Oct 6, 2018
@huafu huafu deleted the release/23.10.4 branch October 6, 2018 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants