fix(ci): set kubebuilder assets directory (backport #3577) #3596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
The `dev/tools` make target installs testing dependencies into $CI_TOOLS_DIR, but the wiring between this and the kubebuilder envtest framework was broken. Make sure that we set the `KUBEBUILDER_ASSETS` environment variable so that the envtest framework can find its dependencies correctly. Signed-off-by: James Peach <james.peach@konghq.com> (cherry picked from commit a9b64a3)
Codecov Report
@@ Coverage Diff @@
## release-1.4 #3596 +/- ##
===============================================
+ Coverage 51.97% 52.01% +0.03%
===============================================
Files 905 905
Lines 54684 54684
===============================================
+ Hits 28422 28442 +20
+ Misses 23982 23961 -21
- Partials 2280 2281 +1
Continue to review full report at Codecov.
|
michaelbeaumont
approved these changes
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #3577 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com