fix(ci): set kubebuilder assets directory #3577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `dev/tools` make target installs testing dependencies into $CI_TOOLS_DIR, but the wiring between this and the kubebuilder envtest framework was broken. Make sure that we set the `KUBEBUILDER_ASSETS` environment variable so that the envtest framework can find its dependencies correctly. Signed-off-by: James Peach <james.peach@konghq.com>
Codecov Report
@@ Coverage Diff @@
## master #3577 +/- ##
==========================================
+ Coverage 51.55% 51.58% +0.03%
==========================================
Files 917 917
Lines 55568 55568
==========================================
+ Hits 28647 28665 +18
+ Misses 24639 24620 -19
- Partials 2282 2283 +1
Continue to review full report at Codecov.
|
mergify bot
pushed a commit
that referenced
this pull request
Dec 20, 2021
The `dev/tools` make target installs testing dependencies into $CI_TOOLS_DIR, but the wiring between this and the kubebuilder envtest framework was broken. Make sure that we set the `KUBEBUILDER_ASSETS` environment variable so that the envtest framework can find its dependencies correctly. Signed-off-by: James Peach <james.peach@konghq.com> (cherry picked from commit a9b64a3)
michaelbeaumont
pushed a commit
that referenced
this pull request
Dec 21, 2021
The `dev/tools` make target installs testing dependencies into $CI_TOOLS_DIR, but the wiring between this and the kubebuilder envtest framework was broken. Make sure that we set the `KUBEBUILDER_ASSETS` environment variable so that the envtest framework can find its dependencies correctly. Signed-off-by: James Peach <james.peach@konghq.com> (cherry picked from commit a9b64a3) Co-authored-by: James Peach <james.peach@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
dev/toolsmake target installs testing dependencies into$CI_TOOLS_DIR, but the wiring between this and the kubebuilder envtestframework was broken. Make sure that we set the
KUBEBUILDER_ASSETSenvironment variable so that the envtest framework can find its
dependencies correctly.
Full changelog
N/A
Issues resolved
N/A
Documentation
N/A
Testing
Manual testing on UniversalManual testing on KubernetesBackwards compatibility
UpdateUPGRADE.mdwith any steps users will need to take when upgrading.backport-to-stablelabel if the code is backwards compatible. Otherwise, list breaking changes.