fix: propagate unexpected test errors via the test framework #1559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 16, 2023 11:03
…ed if it does occur
…d err2 also to be safe.
omar711
changed the title
adschwartz
approved these changes
Oct 16, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 16, 2023
🤖 I have created a release *beep* *boop* --- ## [0.84.7](0.84.6...0.84.7) (2023-10-16) ### Features * Add create enclave utils to SDK ([#1550](#1550)) ([eb952bb](eb952bb)) * provide granular progress of starlark package run ([#1548](#1548)) ([8b20031](8b20031)) * rename kurtosis context "switch" to "set" ([#1537](#1537)) ([ccff275](ccff275)) ### Bug Fixes * propagate unexpected test errors via the test framework ([#1559](#1559)) ([c463ae2](c463ae2)) * show container status instead of service status in enclave inspect ([#1560](#1560)) ([3e1208b](3e1208b)), closes [#1351](#1351) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When an unexpected error happens in
enclave_context.RunStarlarkPackageBlocking, it will return(nil, error). Some tests don't account for this, so they don't detect or report said error, then panic when trying to reference thenilresult.This adds
require.NoError(t, err)to all the tests I could find that hit this codepath.Is this change user facing?
NO
References (if applicable):
#1538