feat!: Applying RFC-1123 standard to service names #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
07c0a86
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d55c6cf0.kurtosis-docs.pages.dev |
| Branch Preview URL: | https://anders-rfc-1123.kurtosis-docs.pages.dev |
gbouv
approved these changes
Jun 21, 2023
container-engine-lib/lib/backend_interface/objects/service/service.go
Outdated
Show resolved
Hide resolved
...api_container/server/startosis_engine/kurtosis_instruction/add_service/add_service_shared.go
Show resolved
Hide resolved
...server/api_container/server/startosis_engine/kurtosis_instruction/add_service/add_service.go
Outdated
Show resolved
Hide resolved
adschwartz
changed the title
adschwartz
changed the title
adschwartz
changed the title
adschwartz
pushed a commit
that referenced
this pull request
Jun 21, 2023
🤖 I have created a release *beep* *boop* --- ## [0.80.0](0.79.0...0.80.0) (2023-06-21) ### ⚠ BREAKING CHANGES * Applying RFC-1123 standard to service names ([#749](#749)) ### Features * Applying RFC-1123 standard to service names ([#749](#749)) ([66a5ebe](66a5ebe)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is a followup to #713. The main change is to apply the RFC-1123 standard to how services are named. This is to ensure compatibility when launching services on k8s.
I've run this on all our packages in
awesome-kurtosisand all the packages referenced in there and fixed a few packages that had noncompliant naming standard.Since this is a breaking release we should wait to coordinate with @leeederek.
Is this change user facing?
YES