feat: added wait to run_sh task. #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
98be2b7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://89d50e87.kurtosis-docs.pages.dev |
| Branch Preview URL: | https://pk-add-wait-to-run-sh.kurtosis-docs.pages.dev |
|
This is the output with wait set to 40s and command that takes 50s 
|
|
Also fixed the wait for exec recipe ( this is an example with ready conditions) Sample Code: Output: |
Peeeekay
force-pushed
the
pk/add_wait_to_run_sh
branch
from
90e8159
to
31feb4b
Compare
laurentluce
reviewed
Jun 21, 2023
core/server/api_container/server/startosis_engine/kurtosis_instruction/run_sh/run_sh.go
Outdated
Show resolved
Hide resolved
core/server/api_container/server/startosis_engine/kurtosis_instruction/run_sh/run_sh.go
Outdated
Show resolved
Hide resolved
done with wait added test for wait made some cosmetics change added wait added to doc and plugin
Peeeekay
force-pushed
the
pk/add_wait_to_run_sh
branch
from
31feb4b
to
6e669a3
Compare
laurentluce
approved these changes
Jun 22, 2023
victorcolombo
pushed a commit
that referenced
this pull request
Jun 26, 2023
🤖 I have created a release *beep* *boop* --- ## [0.80.1](0.80.0...0.80.1) (2023-06-26) ### Features * Add Rust protobuf bindings ([#765](#765)) ([0e47003](0e47003)) * added wait to run_sh task. ([#750](#750)) ([8c2b697](8c2b697)) * Implemented rename enclave method in container engine lib ([#755](#755)) ([f1570f7](f1570f7)) * Persist enclave plan in the Starlark executor memory ([#757](#757)) ([2c3d74e](2c3d74e)) * Start and Stop service Starlark instructions for K8S ([#756](#756)) ([fb3e922](fb3e922)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added wait field to run_sh task.
The intention is that user can set a wait time-out and if the command is not completed before the time-out, it will fail. In this PR, I have also fixed the wait and ready-condition bug observed on k8s with exec-recipe.