-
Notifications
You must be signed in to change notification settings - Fork 16
KUZ-410: normalize chaining #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Current coverage is 100% (diff: 100%)@@ develop #108 diff @@
=====================================
Files 15 15
Lines 1631 1522 -109
Methods 278 258 -20
Messages 0 0
Branches 397 393 -4
=====================================
- Hits 1631 1522 -109
Misses 0 0
Partials 0 0
|
}; | ||
|
||
/** | ||
* Gets the rights array of the currently logged user. | ||
* | ||
* @param {object} [options] - Optional parameters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so the options
parameter should be removed from the function definition?
Kuzzle.prototype.getMyRights = function (options, cb) {
// (...)
if (!cb && typeof options === 'function') {
cb = options;
options = null;
}
// (...)
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, this seems to be an old mistake. Fixing it right away.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Need to clean-up the jsdoc: Despite of that, 👍 for me ;) |
Dang, you're right about jsdoc :-( It has been updated. |
.eslintrc
is now deprecated, using.eslintrc.json
instead