[MASTER] KUZ-683 allow changing host #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 100% (diff: 100%)@@ master #115 diff @@
====================================
Files 16 16
Lines 1550 1552 +2
Methods 264 264
Messages 0 0
Branches 398 398
====================================
+ Hits 1550 1552 +2
Misses 0 0
Partials 0 0
|
scottinet
changed the title
|
This PR merges the changes into the |
xbill82
approved these changes
Sep 21, 2016
j33f
approved these changes
Sep 21, 2016
|
Shouldn't ioPort and wsPort be writable as well ? |
j33f
approved these changes
Sep 21, 2016
|
@dbengsch > saw that too while updating the Android SDK :p |
j33f
approved these changes
Sep 21, 2016
stafyniaksacha
approved these changes
Sep 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of being read-only, the
host,ioPortandwsPortattributes from theKuzzleobject should be writable to allow changing them between connections.And when invoking
Kuzzle.connect, if a network connection has previously been established, thenKuzzle.disconnectis called beforehand.