add queryError event #117
Merged
add queryError event #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 100% (diff: 100%)@@ develop #117 diff @@
=====================================
Files 16 16
Lines 1552 1553 +1
Methods 264 264
Messages 0 0
Branches 398 398
=====================================
+ Hits 1552 1553 +1
Misses 0 0
Partials 0 0
|
j33f
approved these changes
Sep 21, 2016
scottinet
suggested changes
Sep 21, 2016
| @@ -57,7 +57,8 @@ module.exports = Kuzzle = function (host, options, cb) { | |||
| jwtTokenExpired: {lastEmitted: null, listeners: []}, | |||
| loginAttempt: {lastEmitted: null, listeners: []}, | |||
| offlineQueuePush: {listeners: []}, | |||
| offlineQueuePop: {listeners: []} | |||
| offlineQueuePop: {listeners: []}, | |||
| queryError: {lastEmitted: null, listeners: []} | |||
There was a problem hiding this comment.
Adding the lastEmitted property automatically prevents this event being fired more than once every this.eventTimeout ms (currently set to 200ms).
We may not want to throttle this.
scottinet
approved these changes
Sep 21, 2016
|
Do you plan to add this one to android and ios? |
|
I need to have the actual pending PRs on iOS SDK to be merged then I'll figure out how to implement it |
|
It can be delayed, JIRA Ticket was written |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.