Skip to content

Conversation

benoitvidis
Copy link
Contributor

@benoitvidis benoitvidis commented May 28, 2019

What does this PR do?

Imports the SDK v6 documentation in the doc/6/ folder and integrates snippet testing.

How to test?

  • npm run doc-testing (you may previously want to docker-compose -f .ci/doc/docker-compose.yml pull)
  • go see Travis builds and check if everything is OK

Boyscout

@benoitvidis iz teh dude

@benoitvidis benoitvidis force-pushed the poc-documentation-v6 branch from 0dae18b to 907de19 Compare May 29, 2019 07:49
@codecov
Copy link

codecov bot commented May 29, 2019

Codecov Report

Merging #399 into 6-dev will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            6-dev     #399      +/-   ##
==========================================
- Coverage   96.31%   96.29%   -0.02%     
==========================================
  Files          32       32              
  Lines        1519     1538      +19     
==========================================
+ Hits         1463     1481      +18     
- Misses         56       57       +1
Impacted Files Coverage Δ
src/controllers/searchResult/base.js 93.44% <0%> (+0.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69ea980...cc67b24. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Jun 6, 2019

Codecov Report

Merging #399 into 6-dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            6-dev     #399   +/-   ##
=======================================
  Coverage   96.31%   96.31%           
=======================================
  Files          32       32           
  Lines        1519     1519           
=======================================
  Hits         1463     1463           
  Misses         56       56

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34c96e9...aa71e97. Read the comment docs.

@xbill82 xbill82 self-assigned this Jun 28, 2019
@xbill82 xbill82 changed the title [poc] add documentation and related tests Documentation v6 and Snippet Tests Jun 28, 2019
@Aschen Aschen merged commit eb52b44 into 6-dev Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants