Skip to content

Conversation

Aschen
Copy link
Contributor

@Aschen Aschen commented Jul 16, 2020

What does this PR do?

Adds TS support for the Document controller

@Aschen Aschen changed the base branch from 7-dev to add-typescript-support-auth July 16, 2020 10:25
@codecov
Copy link

codecov bot commented Jul 16, 2020

Codecov Report

Merging #527 into add-typescript-support-auth will decrease coverage by 2.07%.
The diff coverage is 70.70%.

Impacted file tree graph

@@                       Coverage Diff                       @@
##           add-typescript-support-auth     #527      +/-   ##
===============================================================
- Coverage                        93.20%   91.13%   -2.08%     
===============================================================
  Files                               32       32              
  Lines                             1354     1387      +33     
  Branches                            85      129      +44     
===============================================================
+ Hits                              1262     1264       +2     
- Misses                              72       98      +26     
- Partials                            20       25       +5     
Impacted Files Coverage Δ
src/controllers/Auth.ts 75.94% <ø> (ø)
src/core/searchResult/SearchResultBase.ts 77.58% <50.00%> (ø)
src/controllers/Document.ts 71.11% <71.11%> (ø)
src/Kuzzle.ts 87.55% <100.00%> (ø)
src/core/searchResult/Document.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36e6649...d5f2fe1. Read the comment docs.

Aschen and others added 5 commits July 21, 2020 10:55
Co-authored-by: Sébastien Cottinet <scottinet@protonmail.com>
Co-authored-by: Sébastien Cottinet <scottinet@protonmail.com>
…/sdk-javascript into add-typescript-support-document
@Leodau Leodau merged commit 6cdd726 into add-typescript-support-auth Jul 21, 2020
@Leodau Leodau deleted the add-typescript-support-document branch July 21, 2020 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants