-
Notifications
You must be signed in to change notification settings - Fork 17
Add typescript support for Document controller #527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Leodau
merged 14 commits into
add-typescript-support-auth
from
add-typescript-support-document
Jul 21, 2020
Merged
Add typescript support for Document controller #527
Leodau
merged 14 commits into
add-typescript-support-auth
from
add-typescript-support-document
Jul 21, 2020
+961
−285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## add-typescript-support-auth #527 +/- ##
===============================================================
- Coverage 93.20% 91.13% -2.08%
===============================================================
Files 32 32
Lines 1354 1387 +33
Branches 85 129 +44
===============================================================
+ Hits 1262 1264 +2
- Misses 72 98 +26
- Partials 20 25 +5
Continue to review full report at Codecov.
|
scottinet
suggested changes
Jul 21, 2020
Co-authored-by: Sébastien Cottinet <scottinet@protonmail.com>
Co-authored-by: Sébastien Cottinet <scottinet@protonmail.com>
…/sdk-javascript into add-typescript-support-document
scottinet
approved these changes
Jul 21, 2020
Leodau
approved these changes
Jul 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds TS support for the Document controller