Skip to content

Conversation

Aschen
Copy link
Contributor

@Aschen Aschen commented Jul 22, 2020

What does this PR do?

Convert realtime controller to TS

⚠️ The whole SDK does not works with TS now since we need to convert every exported class

| Name | Type | Description |
| --------- | ----------------- | ---------------- |
| `userId` | <pre>string</pre> | User kuid |
<<<<<<< HEAD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

;)

@codecov
Copy link

codecov bot commented Jul 31, 2020

Codecov Report

❗ No coverage uploaded for pull request base (7-dev@005269a). Click here to learn what that means.
The diff coverage is 90.32%.

Impacted file tree graph

@@           Coverage Diff            @@
##             7-dev     #528   +/-   ##
========================================
  Coverage         ?   90.96%           
========================================
  Files            ?       32           
  Lines            ?     1406           
  Branches         ?      136           
========================================
  Hits             ?     1279           
  Misses           ?      100           
  Partials         ?       27           
Impacted Files Coverage Δ
src/controllers/Auth.ts 75.94% <ø> (ø)
src/controllers/Document.ts 71.91% <ø> (ø)
src/core/Room.js 100.00% <ø> (ø)
src/controllers/Realtime.ts 90.32% <90.32%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 005269a...fb69d92. Read the comment docs.

@Aschen
Copy link
Contributor Author

Aschen commented Aug 10, 2020

See this PR instead because Travis have a bug on this one

@Aschen Aschen closed this Aug 10, 2020
@Aschen Aschen deleted the add-typescript-support-realtime branch August 10, 2020 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants