Skip to content

Conversation

Aschen
Copy link
Contributor

@Aschen Aschen commented Nov 13, 2020

What does this PR do?

Export more interfaces to offer more flexibility to developers when they are using the SDK.

Also the Document class has been modifier to be able to extend it:

interface AlertContent extends DocumentContent {
  name: string;

  description: string;

  // _kuzzle_info is included from DocumentContent
}

class Alert extends Document {
  public _source: AlertContent;

  constructor () {
    super();
  }
}

@Aschen Aschen self-assigned this Nov 13, 2020
@Aschen Aschen marked this pull request as draft November 13, 2020 15:49
@codecov
Copy link

codecov bot commented Nov 13, 2020

Codecov Report

Merging #556 (dddd238) into 7-dev (7d41dc3) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            7-dev     #556      +/-   ##
==========================================
- Coverage   88.39%   88.38%   -0.01%     
==========================================
  Files          32       32              
  Lines        1448     1447       -1     
  Branches      252      252              
==========================================
- Hits         1280     1279       -1     
  Misses        119      119              
  Partials       49       49              
Impacted Files Coverage Δ
src/controllers/Realtime.ts 90.47% <ø> (-0.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d41dc3...dddd238. Read the comment docs.

@Aschen Aschen marked this pull request as ready for review November 13, 2020 16:06
@rolljee rolljee merged commit 0a1ed1f into 7-dev Nov 16, 2020
@rolljee rolljee deleted the typescript-improvements branch November 16, 2020 08:29
@Aschen Aschen mentioned this pull request Nov 19, 2020
Aschen added a commit that referenced this pull request Nov 19, 2020
# [7.4.2](https://github.com/kuzzleio/sdk-javascript/releases/tag/7.4.2) (2020-11-19)


#### Enhancements

- [ [#556](#556) ] Export more interfaces for Typescript   ([Aschen](https://github.com/Aschen))
---
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants