Skip to content

Conversation

Aschen
Copy link
Contributor

@Aschen Aschen commented Nov 23, 2020

What does this PR do?

Remove the stacktrace enhancement. It's buggy and not accurate, we need another way to do that but for now I'm just going to remove it

@codecov
Copy link

codecov bot commented Nov 23, 2020

Codecov Report

Merging #559 (4d3b0bf) into master (6cb1eaa) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #559      +/-   ##
==========================================
- Coverage   88.38%   88.34%   -0.05%     
==========================================
  Files          32       32              
  Lines        1447     1442       -5     
  Branches      252      251       -1     
==========================================
- Hits         1279     1274       -5     
  Misses        119      119              
  Partials       49       49              
Impacted Files Coverage Δ
src/KuzzleError.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cb1eaa...4d3b0bf. Read the comment docs.

@Aschen Aschen merged commit 63f8fd2 into master Nov 23, 2020
@Aschen Aschen deleted the remove-stacktrace-enhancement branch November 23, 2020 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants