Skip to content

Conversation

Shiranuit
Copy link
Contributor

What does this PR do ?

This PR change the behaviour of the websocket's connect method to call HttpProtocol.connect() if the support of cookieAuthentication is enabled.
Without that the HttpProtocol routes are not constructed, causing it to not send the payloads.

How should this be manually tested?

npm run test

Other changes

Correction of a wrong statement in the cookieAuth option of the Kuzzle constructor.

@codecov
Copy link

codecov bot commented Apr 28, 2021

Codecov Report

Merging #635 (c1c6ecf) into master (f0beacc) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head c1c6ecf differs from pull request most recent head 1a626f8. Consider uploading reports for the commit 1a626f8 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #635      +/-   ##
==========================================
+ Coverage   86.15%   86.18%   +0.03%     
==========================================
  Files          34       34              
  Lines        1589     1593       +4     
  Branches      279      280       +1     
==========================================
+ Hits         1369     1373       +4     
  Misses        162      162              
  Partials       58       58              
Impacted Files Coverage Δ
src/protocols/WebSocket.ts 80.50% <100.00%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0beacc...1a626f8. Read the comment docs.

@scottinet scottinet changed the title Hotfix ws cookie auth Fix cookie authentication support for WebSocket Apr 28, 2021
Copy link
Contributor

@scottinet scottinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing package version bump (run npm version patch and commit the changes)

@Shiranuit Shiranuit merged commit 1e9bdf1 into master May 3, 2021
@Shiranuit Shiranuit deleted the hotfix-ws-cookie-auth branch May 3, 2021 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants