Support entire query for security:searchProfiles #667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 7-dev #667 +/- ##
==========================================
+ Coverage 83.40% 83.81% +0.41%
==========================================
Files 36 39 +3
Lines 1766 1885 +119
Branches 324 343 +19
==========================================
+ Hits 1473 1580 +107
- Misses 227 237 +10
- Partials 66 68 +2
Continue to review full report at Codecov.
|
added 2 commits
October 3, 2021 09:36
xbill82
approved these changes
Oct 5, 2021
alexandrebouthinon
approved these changes
Nov 8, 2021
| from: undefined, | ||
| size: undefined, | ||
| scroll: undefined | ||
| opt: 'in' |
There was a problem hiding this comment.
I personally prefer to add a test than to modify an existing one even if you copy/paste it
| @@ -1067,8 +1065,7 @@ describe('Security Controller', () => { | |||
| controller: 'security', | |||
| action: 'searchRoles', | |||
| body: {controllers: ['foo', 'bar']}, | |||
| from: undefined, | |||
| size: undefined | |||
| opt: 'in', | |||
There was a problem hiding this comment.
I personally prefer to add a test than to modify an existing one even if you copy/paste it
rolljee
approved these changes
Nov 9, 2021
added 2 commits
November 25, 2021 19:23
Shiranuit
approved these changes
Jan 12, 2022
Merged
Aschen
added a commit
that referenced
this pull request
Jan 27, 2022
# [7.8.3](https://github.com/kuzzleio/sdk-javascript/releases/tag/7.8.3) (2022-01-27) #### Bug fixes - [ [#683](#683) ] Fix authenticator token verification ([Shiranuit](https://github.com/Shiranuit)) #### Enhancements - [ [#680](#680) ] Add debug mode ([Aschen](https://github.com/Aschen)) - [ [#676](#676) ] Add HTTP protocol support for Observer ([Aschen](https://github.com/Aschen)) - [ [#667](#667) ] Support entire query for security:searchProfiles ([Aschen](https://github.com/Aschen)) - [ [#669](#669) ] Add more context to errors ([clementbolin](https://github.com/clementbolin)) #### Others - [ [#674](#674) ] Add types for mRequests and mResponses ([Aschen](https://github.com/Aschen)) ---
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Since Kuzzle 2.14.1, the
security:searchProfilesaction can take a search query.This PR update the SDK and doc to support this.
Other changes