Add index and collection fields to KHit #726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmauNeko
force-pushed
the
feature/extend-khit
branch
from
b2cf489 to
40d589d
Compare
Codecov Report
@@ Coverage Diff @@
## 7-dev #726 +/- ##
=======================================
Coverage 83.02% 83.02%
=======================================
Files 46 46
Lines 2115 2115
Branches 408 408
=======================================
Hits 1756 1756
Misses 280 280
Partials 79 79 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Aschen
suggested changes
Apr 12, 2023
Aschen
approved these changes
Apr 13, 2023
fmauNeko
requested review from
OlivierCavadenti and
Kuruyia
and removed request for
alexandrebouthinon and
Shiranuit
OlivierCavadenti
approved these changes
Apr 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
It adds
indexandcollectiontoKHit<>.Those fields are necessary for the multi-search results.