Kuz 490 repositories refactor #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 100%
|
added 2 commits
July 15, 2016 14:45
added 2 commits
July 18, 2016 11:38
|
+1 |
| * @param {responseCallback} cb - returns Kuzzle's response | ||
| */ | ||
| KuzzleSecurity.prototype.getUser = function (id, options, cb) { | ||
| KuzzleSecurity.prototype.getUser = function (id, cb) { |
There was a problem hiding this comment.
The options parameter should stay: it may contain a queued option, handling offline mode.
See: http://kuzzle.io/sdk-documentation/#getuser
| @@ -4008,11 +4008,16 @@ KuzzleSecurity.prototype.roleFactory = function(id, content) { | |||
| * @param {string} id | |||
| * @param {responseCallback} cb - returns Kuzzle's response | |||
| */ | |||
| KuzzleSecurity.prototype.getProfile = function (id, cb) { | |||
| KuzzleSecurity.prototype.getProfile = function (id, options, cb) { | |||
There was a problem hiding this comment.
The jsdoc must also be restored.
|
+1 |
| * Add a role in the roles list | ||
| * @param {KuzzleRole|string} role - can be an instance of KuzzleRole or an id in string | ||
| * Add a policy in the policies list | ||
| * @param {Object} role - must be an object containing at least a "roleId" member which must be a string. |
There was a problem hiding this comment.
nitpicking: the param name is "policy" and not "role"
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.