src: vm: Add dependency for vm deploy and update remote kw path #678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 74.28% // Head: 74.28% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## unstable #678 +/- ##
=========================================
Coverage 74.28% 74.28%
=========================================
Files 39 39
Lines 6273 6273
=========================================
Hits 4660 4660
Misses 1613 1613
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
hilookas
changed the title
rodrigosiqueira
requested changes
Sep 13, 2022
After commit dabb285, `kw_path` was deprecated. See `update_deploy_variables` in `deploy.sh`. An test is added to cover this case. This commit also adds missing dependency `libguestfs-tools` for `guestmount` and `guestfish` in debian and arch linux. Closes kworkflow#246 Closes kworkflow#677 Signed-off-by: Haiqin Cui <i@18kas.com>
|
Nice addition! Thanks a lot! Merged into the unstable branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After commit dabb285,
kw_pathwas deprecated.See
update_deploy_variablesindeploy.sh.This commit also adds missing dependency
libguestfs-toolsforguestmountandguestfish.Closes #246
Closes #677
Signed-off-by: Haiqin Cui i@18kas.com